Skip to content

Commit

Permalink
net: fix USB network driver config option.
Browse files Browse the repository at this point in the history
It must be tristate to avoid broken dependencies with kernel built-in
usb network drivers when usb support is module only.

When net config option is set, least surprize default should match usb.

Wireless RNDIS USB driver used to select USB_USBNET. USB_USBNET now
depends on USB_NET_DRIVERS so the latter should be selected as well.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Francois Romieu authored and davem330 committed Aug 6, 2014
1 parent 753a2ad commit 269f8cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/usb/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ comment "Host-side USB support is needed for USB Network Adapter support"
depends on !USB && NET

menuconfig USB_NET_DRIVERS
bool "USB Network Adapters"
default y
tristate "USB Network Adapters"
default USB if USB
depends on USB && NET

if USB_NET_DRIVERS
Expand Down
1 change: 1 addition & 0 deletions drivers/net/wireless/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ config USB_NET_RNDIS_WLAN
tristate "Wireless RNDIS USB support"
depends on USB
depends on CFG80211
select USB_NET_DRIVERS
select USB_USBNET
select USB_NET_CDCETHER
select USB_NET_RNDIS_HOST
Expand Down

0 comments on commit 269f8cb

Please sign in to comment.