Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cart.php #15

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Update Cart.php #15

merged 1 commit into from
Jul 5, 2020

Conversation

OscarKolsrud
Copy link

Fixed a bug where 0 is passed as the taxrate to the Cart:add facade resulting in it not evaluating right since '0' is not true in a if statement. Changed therefore the comparison to isset() so it rather checks if there is passed a taxrate of some kind. Also added in the if statement a simple check to see if the taxrate is numeric, and if not default to the one in the config

Fixed a bug where 0 is passed as the taxrate to the Cart:add facade resulting in it not evaluating right since '0' is not true in a if statement. Changed therefore the comparison to isset() so it rather checks if there is passed a taxrate of some kind. Also added in the if statement a simple check to see if the taxrate is numeric, and if not default to the one in the config
@hardevine hardevine merged commit 08f7e19 into hardevine:master Jul 5, 2020
@hardevine
Copy link
Owner

thanks

@OscarKolsrud
Copy link
Author

Thanks for merging @hardevine . Maybe you can also publish the update on packagist so it becomes available easily in composer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants