Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gs_usb: Use BitTiming to configure bitrate. #1748

Merged
merged 2 commits into from
Jun 22, 2024
Merged

gs_usb: Use BitTiming to configure bitrate. #1748

merged 2 commits into from
Jun 22, 2024

Conversation

tuwuhs
Copy link
Contributor

@tuwuhs tuwuhs commented Feb 26, 2024

Solves #1747

@zariiii9003
Copy link
Collaborator

You should format your code with black to make the tests pass. Otherwise this looks fine.
It's outside of the scope of this PR, but you could add the timing parameter like in kvaser, pcan, vector etc. if you don't mind.

@zariiii9003 zariiii9003 merged commit 70901ea into hardbyte:main Jun 22, 2024
28 checks passed
@zariiii9003 zariiii9003 mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuwuhs @zariiii9003