Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update to pypy-3.7 and add Python 3.10 on Ubuntu & MacOS #1143

Merged
merged 4 commits into from
Oct 25, 2021
Merged

ci: Update to pypy-3.7 and add Python 3.10 on Ubuntu & MacOS #1143

merged 4 commits into from
Oct 25, 2021

Conversation

projectgus
Copy link
Contributor

@projectgus projectgus commented Oct 24, 2021 •
edited
Loading

Two CI changes related to Python versions:

@projectgus projectgus mentioned this pull request Oct 24, 2021
Merged
@mergify mergify bot requested a review from hardbyte October 24, 2021 01:05
@codecov
Copy link

codecov bot commented Oct 24, 2021 •
edited
Loading

Codecov Report

Merging #1143 (828fa7c) into develop (71580d8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 828fa7c differs from pull request most recent head d72c7d0. Consider uploading reports for the commit d72c7d0 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1143      +/-   ##
===========================================
- Coverage    70.49%   70.45%   -0.04%     
===========================================
  Files           79       79              
  Lines         7679     7681       +2     
===========================================
- Hits          5413     5412       -1     
- Misses        2266     2269       +3

@projectgus projectgus force-pushed the update/python-versions branch 7 times, most recently from 0a662cf to 770b210 Compare October 24, 2021 02:40
@projectgus
test: Ignore Hypothesis float generation issue with Windows+PyPy-3.7
d72c7d0 
Hypothesis throws a "Flaky" error for inconsistent data on PyPy-3.7 + Windows
only, when generating timestamp fields. I think this is a bug in either
Hypothesis or PyPy, but I don't know which.
@projectgus projectgus force-pushed the update/python-versions branch from 770b210 to d72c7d0 Compare October 24, 2021 02:51
@projectgus
Copy link
Contributor Author

I don't understand this Hypothesis internal error on Windows pypy-3.7. Example log:
https://github.com/hardbyte/python-can/runs/3986654372?check_suite_focus=true

It seems to detect that the representation of the timestamp float is inconsistent between two runs with the same value. I'm guessing it's a bug in either pypy or Hypothesis with float representation, I don't think it's anything that python-can is doing. I tried a few quick workarounds but have marked the test as an expected failure for now.

Something similar sounding was reported here but seems to be solved:
HypothesisWorks/hypothesis#3028

@projectgus
Copy link
Contributor Author

@felixdivo PTAL as well if you have time

@projectgus projectgus marked this pull request as ready for review October 24, 2021 03:39
@felixdivo felixdivo added this to the 4.0.0 Release milestone Oct 25, 2021
@felixdivo felixdivo added the QA about improving and maintaining the quality of the library label Oct 25, 2021
felixdivo
felixdivo approved these changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@felixdivo felixdivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks for investigating.

@felixdivo felixdivo removed the request for review from hardbyte October 25, 2021 20:21
@mergify mergify bot requested a review from hardbyte October 25, 2021 20:22
@felixdivo
Copy link
Collaborator

@hardbyte A quick review by you would be very helpful to fix the CI for all and let new branches be merged. E.g. #1145 depends on it.

hardbyte
hardbyte approved these changes Oct 25, 2021
View reviewed changes
.github/workflows/build.yml
@@ -13,11 +13,16 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
experimental: [false]
python-version: [3.6, 3.7, 3.8, 3.9, pypy3]
python-version: ["3.6", "3.7", "3.8", "3.9", "pypy-3.7"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@hardbyte hardbyte merged commit 352b1f1 into hardbyte:develop Oct 25, 2021
@felixdivo
Copy link
Collaborator

Thanks!

This was referenced Oct 26, 2021
Merged
Closed
cowo78 pushed a commit to cowo78/python-can that referenced this pull request Dec 9, 2021
@projectgus
ci: Update to pypy-3.7 and add Python 3.10 on Ubuntu & MacOS (hardbyt…
69760ef 
…e#1143)

* ci: Change pypy3 to pypy-3.7

PyPy 3.6 is no longer available on the macos-latest (macOS-11) image, see
actions/runner-images#4060

* ci: Use release version Python 3.10, run syntax checks under 3.10

* listener: Fix PyPy 3.7 error passing a timeout parameter together with block=False

* test: Ignore Hypothesis float generation issue with Windows+PyPy-3.7

Hypothesis throws a "Flaky" error for inconsistent data on PyPy-3.7 + Windows
only, when generating timestamp fields. I think this is a bug in either
Hypothesis or PyPy, but I don't know which.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardbyte hardbyte hardbyte approved these changes

@felixdivo felixdivo felixdivo approved these changes

Assignees

@projectgus projectgus

Labels
QA about improving and maintaining the quality of the library
Projects
None yet
Milestone
4.0.0 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@projectgus @felixdivo @hardbyte