Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps for node v14+ #80

Merged
merged 2 commits into from
May 8, 2022
Merged

Upgrade deps for node v14+ #80

merged 2 commits into from
May 8, 2022

Conversation

devinivy
Copy link
Member

@devinivy devinivy commented May 7, 2022

Upgrade hoek, teamwork, validate, lab, code, and typescript for node v14+ support.

If this looks good, this will be the last work going into podium v5.

@devinivy devinivy added dependency Update module dependency breaking changes Change that can breaking existing code labels May 7, 2022
@devinivy devinivy added this to the 5.0.0 milestone May 7, 2022
@Marsup
Copy link
Contributor

Marsup commented May 7, 2022

Apparently, the tests fail because lab doesn't include a new kind of error around here, the new code is 2820. I'm not super familiar with this part of lab so not sure to which array the code should be added (or if it should at all).

@devinivy
Copy link
Member Author

devinivy commented May 7, 2022

Good call— here's that patch in lab hapijs/lab#1051

@devinivy devinivy merged commit 3ed1297 into v5 May 8, 2022
@devinivy devinivy deleted the final-v5-dep-upgrades branch May 8, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code dependency Update module dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants