Hoek.clone drop an error with axios errors in version @hapi/hoek 11.0.6+

[kedderli]

Runtime

node.js

Runtime version

20.17

Module version

11.0.6

Last module version without issue

11.0.4

Used with

No response

Any other relevant information

Function structuredClone drop an error, if clonning object has functions https://github.com/hapijs/hoek/blob/v11.0.6/lib/clone.js#L177

What are you trying to achieve or the steps to reproduce?

const { Boom } = require('@hapi/boom');
const { AxiosError } = require('axios');

const err = new AxiosError('error');

console.log(err instanceof Error); // true

err.fun = () => {};

const boomError = new Boom(err);

console.log(boomError);
console.log(boomError instanceof Error);

What was the result you got?

Got an error like:
node:internal/per_context/domexception:53 ErrorCaptureStackTrace(this); ^ DOMException [DataCloneError]: function httpAdapter(config) { return new Promise(function dispatchHttpRequest(resolvePromise, rejectPromise)...<omitted>... } could not be cloned.

What result did you expect?

Haven't gotten this error on previous version of lib

[Marsup]

I don't think it's generally safe to do this on errors.

You should either create your own custom error class, like so:

class CustomError extends AxiosError {
  foo() {}
}
const err = new CustomError('error');

Or add it as non-enumerable:

const error = new AxiosError('error');
Object.defineProperty(error, 'fun', { value: () => {}, enumerable: false });

[kanongil]

@Marsup I tend to agree, but Hoek should never throw an error when cloning.

Something strange is going on here. I am unable to replicate the issue with regular errors, only AxiosError seem to trigger the issue. It seems that regular (and subclassed) errors passed to structuredClone() will not copy any "own" properties, but when created as AxiosError they suddenly will!

[Marsup]

Doesn't it then become axios's problem?

[Marsup]

Fix is released in 11.0.7, thanks @kanongil for the patch 🙏🏻

[kedderli]

Thanks :)