Error when hawk payload validation is required but the request contains no hash #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hawk authentication and payload verification are required authenticatePayload with throw an error if artifacts.hash is undefined. It should be defined even if the request excluded the hash.
hueniverse
pushed a commit
that referenced
this pull request
Jul 3, 2013
Error when hawk payload validation is required but the request contains no hash
hueniverse
pushed a commit
that referenced
this pull request
Jul 3, 2013
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Error when hawk payload validation is required but the request contains no hash
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hawk authentication and payload verification are required
authenticatePayload with throw an error if artifacts.hash is
undefined.
I'm not sure if this is the right way to fix it, but the test case shows the issue.
Thanks :)
//cc @zaach