Fix multipart encoding #771 #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueniverse
pushed a commit
that referenced
this pull request
Apr 18, 2013
Fix multipart encoding #771
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Fix multipart encoding hapijs#771
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formidable gets the payload buffer after .toString('utf-8') has been called on it. This works for text, but not for binary data in a multipart request. I changed the payload.parse method to pass the 'raw' payload buffer to formidable and updated the test. The test now passes a stream to form-data, so that it encodes the binary data as file in the multipart request and formidable recognizes it as such. The test then compares the filesize and the actual file contents of the source file and the written tmp file. Would be nice if you can take a look at it.