Make content encoder and options explicitly typed and extensible #4490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the typings of the route and payload
compression
options, by explicitly listing the available encoders (gzip
&deflate
) and types all the options.Additionally, it allows users to register types for custom encoders/decoders with its own custom options. Eg.
This will add and type a
br
encoder toservers.encoders()
, and add it to the list ofcompression
options with the expected typings.Note that I deleted the nonsensical
RouteCompressionEncoderSettings
andPayloadCompressionDecoderSettings
type exports (the settings have always been specific to each entry).