Change default CORS preflight status code w/ configuration #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.preflightStatusCode
devinivy
added
feature
Nargonath
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
LGTM. I followed the discussion in #4165 and I don't have any strong opinion on it. As you mentioned it seems there isn't any one-size-fits-all here but 200 seemed to be the most likely to go down without any trouble. If a user ever encounters a problem the option will be there for them to change the default status code so I think we're covered.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work decouples the status code used for CORS preflight responses from the server's
emptyStatusCode. The CORS preflight response status code now defaults to200per conversation in #4165, and is configurable to200or204usingrequest.options.cors.preflightStatusCode.Resolves #4165