Removed Http(s) globalAgent settings #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simply passing maxSockets to Nipple did not take advantage of connection pooling benefits. Rewrote to create Agent within Hapi and pass that for requests. |
| @@ -190,8 +190,8 @@ exports = module.exports = internals.Server = function (/* host, port, options * | |||
| } | |||
|
|
|||
| if (this.settings.maxSockets !== null) { | |||
| Https.globalAgent.maxSockets = this.settings.maxSockets; | |||
| Http.globalAgent.maxSockets = this.settings.maxSockets; | |||
| this.settings.agent = (this.settings.tls ? new Https.Agent() : new Http.Agent()); | |||
There was a problem hiding this comment.
This is wrong. The agent type has nothing to do with the server type. What we need is to create both agents.
hueniverse
pushed a commit
that referenced
this pull request
Mar 12, 2014
Removed Http(s) globalAgent settings
| @@ -122,7 +122,8 @@ internals.serverSchema = { | |||
| views: internals.viewSchema({ | |||
| engines: Joi.object().required() | |||
| }), | |||
| maxSockets: Joi.number().allow(null) | |||
| maxSockets: Joi.number().allow(null), | |||
| agent: Joi.object().allow(null) | |||
There was a problem hiding this comment.
Even the way you had it, there is no need to allow agent as an external option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offloaded maxSockets settings to Nipple. Closes #1346