generateView at 'onRequest' extension point

[joliss]

I'm trying to use request.generateView to generate a custom error page in an 'onRequest' extension function, like so:

server.ext('onRequest', function (request, next) {
  if (errorCondition)
    next(request.generateView('error', {message: 'Foo'}))
  else
    next()
})

request.generateView fails in request.js:716 with

Debug: hapi, uncaught, onRequest, error TypeError: Cannot read property 'env' of null
    at internals.Request.generateView (.../node_modules/hapi/lib/request.js:716:35)

Changing request.js:716 to

    var viewsManager = (this._route && this._route.env.views) || this.server._views;

in order to guard against missing this._route seems to fix it, but I don't know if that's the correct fix. I'm not sure if calling request.generateView at that point is supposed to be supported at all.

[joliss]

My current workaround is to use

new hapi.response.View(request.server._views, 'templateName', context)

in place of request.generateResponse.

[hueniverse]

this._route should never be null. I'll take a look.

[hueniverse]

Ok. The problem is that the route is not matched until right after onRequest, hence the bug. I need to map the flows to figure out the right solution here, but it will need to take into account the environment of the plugin, not just the server (if a plugin is in play).

[joliss]

Lovely, thanks Eran!

P.S. I attended your session at NodeConf, and now I'm using hapi in this build tool I'm writing. It's amazing!

[hueniverse]

Sweet!