-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 not being caught by onPreResponse function #1094
Comments
I updated to 1.14.0 and I am still experiencing the same issue as previously described. |
The referenced commit had the wrong issue in the message. Should have been #1098. |
I can't reproduce it. See commit above with new test added. |
I am facing the exact same issue and I have 1.14. Is the issue fixed? |
The test in cf418cb confirms this working correctly. If you can reproduce the issue in 1.17 please open a new issue. |
I am seeing the 404 JSON response returned to the browser, but the status code (response._code) in the onPreResponse function below is 200. Additionally, response.isBoom is undefined. I am running version 1.13.0. Based on the documentation I would expect this to catch 404's. It is catching 500's. Is there something I am missing?
The text was updated successfully, but these errors were encountered: