Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis workflow with GitHub action #140

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

lauraseidler
Copy link
Collaborator

This keeps the existing matrix intact, but also adds node 14 and 16.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(seems tests failing)

This keeps the existing matrix intact, but also adds node 14 as the current LTS.
@lauraseidler lauraseidler marked this pull request as ready for review September 29, 2021 13:30
@lauraseidler
Copy link
Collaborator Author

Yeah I'm not 100% sure what's going wrong with Node 16 - I've removed it for now, as 14 is still the LTS anyways, will take a look at it again later.

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants