Don't create a reporter if no streams were provided. Addresses #534 (#…

…535) * Don't create a reporter if no streams were provided. Closes #534 * Change test for no stream to assert other reporters are still created
hapijs · Nov 21, 2016 · f957062 · f957062
1 parent 9d198f8
commit f957062
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/lib/monitor.js b/lib/monitor.js
@@ -93,6 +93,10 @@ class Monitor {
 
         internals.forOwn(this.settings.reporters, (reporterName, streamsSpec) => {
 
+            if (!streamsSpec.length) {
+                return;
+            }
+
             const streamObjs = [];
             for (let i = 0; i < streamsSpec.length; ++i) {
                 const spec = streamsSpec[i];

diff --git a/test/monitor.js b/test/monitor.js
@@ -245,6 +245,26 @@ describe('Monitor', () => {
 
             done();
         });
+
+        it('does not create a reporter if the reporter has no streams', { plan: 3 }, (done) => {
+
+            const monitor = internals.monitorFactory(new Hapi.Server(), {
+                reporters: {
+                    foo: [],
+                    bar: [new GoodReporter.Incrementer(1)]
+                }
+            });
+
+            monitor.start((error) => {
+
+                expect(error).to.not.exist();
+
+                expect(monitor._reporters).to.have.length(1);
+                expect(monitor._reporters.bar).to.exist();
+
+                done();
+            });
+        });
     });
 
     describe('push()', () => {