2025 01 gg ai #1883
2025 01 gg ai #1883
Conversation
org.hl7.fhir.utilities/src/main/java/org/hl7/fhir/utilities/filesystem/ManagedFileAccess.java
Show resolved
Hide resolved
|
|
||
| protected String getSystemName(String system) { | ||
| switch (system) { | ||
| case "http://snomed.info/sct": return "SNOMED CT"; |
There was a problem hiding this comment.
Are these always http and never https?
| ve.seeResource(new JsonParser().parse(TestingUtilities.loadTestResourceStream("validator", "resolution", "StructureDefinition-Patient.json"))); | ||
| OperationOutcome op = ve.validate(FhirFormat.JSON, TestingUtilities.loadTestResourceStream("validator", "resolution", "relative-url-invalid.json"), null); | ||
| Assertions.assertTrue(checkOutcomes("testResolveRelativeFileValid", op, | ||
| "Observation.subject null error/structure: Unable to find a profile match for Patient/example-newborn among choices: http://hl7.org/fhir/test/StructureDefinition/PatientRule\n"+ |
There was a problem hiding this comment.
The error message here is a little hard to follow. It can't find the subject because the reference is Patient/example-newborn and the closest available ID is newborn, which means the mentioned profile is not satisfied. Is that the correct interpretation?
There was a problem hiding this comment.
it resolves to a resource that is not valid against the profile it is required to conform to. Agree they are hard to follow because what is being tested is an obscure corner case
| ve.seeResource(new JsonParser().parse(TestingUtilities.loadTestResourceStream("validator", "resolution", "StructureDefinition-Patient.json"))); | ||
| OperationOutcome op = ve.validate(FhirFormat.JSON, TestingUtilities.loadTestResourceStream("validator", "resolution", "relative-url-error.json"), null); | ||
| Assertions.assertTrue(checkOutcomes("testResolveRelativeFileValid", op, | ||
| "Observation.subject null error/structure: Unable to resolve resource with reference 'patient/example-newborn-x'\n"+ |
There was a problem hiding this comment.
How is this different from example-newborn when Patient/newborn should be the only resource found?
There was a problem hiding this comment.
because it won't find any resource in this case
| literalPath = refPath + "->" + element.getName(); | ||
| int i = element.getName().indexOf("."); | ||
| if (i == -1) { | ||
| literalPath = refPath+".resolve().ofType(" + element.getName()+")"; |
There was a problem hiding this comment.
Do elements have path formatted names?
Patient.name with refpath Some.ref.path becomes Some.ref.path.resolve().ofType(Patient).name?
There was a problem hiding this comment.
well, they do. It was -> instead of .resolve() which is illegal, so I'm just normalising that. I looked at reworking the way element paths happen completely but it was a harder problem than I expected, so I backed out those changes. maybe another day
| @@ -1015,6 +1023,30 @@ public void validate(Object appContext, List<ValidationMessage> errors, String p | |||
| codingObserver.finish(errors, stack); | |||
| errors.removeAll(messagesToRemove); | |||
| timeTracker.overall(t); | |||
There was a problem hiding this comment.
Should AI run after time tracking for overall validation, or should AI be included in overall time?
… track & report expansion source And render supplement dependencies + correct error handling for expansion failure
…plicit value sets
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1883 +/- ##
============================================
+ Coverage 12.86% 12.89% +0.03%
- Complexity 33784 33922 +138
============================================
Files 2240 2248 +8
Lines 684894 685706 +812
Branches 202227 202370 +143
============================================
+ Hits 88084 88431 +347
- Misses 565505 565922 +417
- Partials 31305 31353 +48 ☔ View full report in Codecov by Sentry. |
No description provided.