-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retrive retitle if no good title provided #93
Conversation
shohoku11wrj
commented
Nov 25, 2018
/** | ||
* retrieve any matched values in content | ||
*/ | ||
private getValue(content:string, values:Array<any>, defaultValue:string): string{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Includes and getValue can be rewrite into
let matcher = new RegEx(targets.join('|'))
and it can be used to match any values there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to "getFirstMatch()", the values should have priorities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the comments inline
change to new pull request #97 |