Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrive retitle if no good title provided #93

Closed
wants to merge 10 commits into from

Conversation

shohoku11wrj
Copy link
Collaborator

image

/**
* retrieve any matched values in content
*/
private getValue(content:string, values:Array<any>, defaultValue:string): string{
Copy link
Collaborator

@xinbenlv xinbenlv Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Includes and getValue can be rewrite into

let matcher = new RegEx(targets.join('|')) 

and it can be used to match any values there?

Copy link
Collaborator Author

@shohoku11wrj shohoku11wrj Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to "getFirstMatch()", the values should have priorities.

Copy link
Collaborator

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the comments inline

@shohoku11wrj shohoku11wrj changed the base branch from master to dev December 10, 2018 00:56
@shohoku11wrj
Copy link
Collaborator Author

change to new pull request #97

@ghost ghost removed the in progress label Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants