-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Barycentric Coordinates #804
Open
luke-wriglesworth
wants to merge
16
commits into
hannorein:main
Choose a base branch
from
luke-wriglesworth:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-wriglesworth
force-pushed
the
main
branch
from
November 17, 2024 08:30
2ae807a
to
aeea23a
Compare
luke-wriglesworth
force-pushed
the
main
branch
from
November 17, 2024 15:19
aeea23a
to
3a2e3df
Compare
…rything at the end. Transformation error looks similar to other coordinate systems now.
… perfectly, but for differing masses it will need to be changed to something more general. For systems with more than two bodies I set it to use the first mass as eta. This works much better than using the total system mass in all scenarios I tested it with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the transformations I used something similar to Jacobi coordinates, where the first coordinate points to the center of mass and the other coordinates are calculated relative to it.