Make edge approximation more robust #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we no longer rely on curve approximations to deliver accurate representations of the edge vertices. I add a comment in the commit that explains why relying on this could be a problem. This change gives the curves some more flexibility. So far, they need to deliver these accurate representations of the vertices, which limits the kinds of curves that can be implemented. This limitation is now lifted, enabling the implementation of other kinds of curves, like lines that were swept from a vertex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactoring, meaning it doesn't actually fix any robustness issues. But it does make the edge approximation code more robust, meaning some requirements on the neighboring curve approximation code are lifted. This will enable adding more interesting curves, which is required for a follow-up refactoring I'm going to tackle next, which is needed to address #97.