Validate that coincident vertices within Sketch
are identical
#1689
Labels
good first issue
Good for newcomers
topic: validation
Infrastructure for checking various properties of objects, making sure they are valid.
type: feature
New features and improvements to existing features
Shapes in the Fornjot kernel are made up of objects (faces, edges, vertices, ...). Those objects are managed in a centralized data store, and their location in that store gives them a unique identity. This means that two objects that have been created at different types are never identical, even if they are equal (i.e. contain the same data).
If two vertices within a
Sketch
orSolid
are equal (or really close together) but not identical, this is a bug. If two vertices are meant to be equal, but aren't identical, then they can end up with slightly different positions, depending on various factors, which would result in an error down the line (either a approximation failure, or an invalid triangle mesh being generated). It would be best to have validation checks to protect against this.This would involve two different but similar validation checks: One for
Sketch
, one forSolid
. Those checks should use the validation configuration to determine which vertices should be identical.The text was updated successfully, but these errors were encountered: