Resource handlers support

[j-barata]

Hello,

I'm trying to setup a resource provider within a plugin (the resources shall be provided by the plugin itself), and tried the following code :

@configuration
@EnableWebMvc
public class ImageProvider implements WebMvcConfigurer {
@OverRide
public void addResourceHandlers(ResourceHandlerRegistry registry) {
registry.addResourceHandler("/icons/*").addResourceLocations("classpath:/icons/");
}
}

But I only get a 404 Error.

Is this kind of feature currently supported ?
Thanks

[hank-cp]

SBP supports resource loading. Please check out this document that explain how sbp load resources.

and here are related the test cases:

• sbp/demo-app/src/test/java/demo/sbp/app/PluginIntegrationTest.java

  Line 223 in d14a98f

  public void loadResourceFromPluginFirst() throws IOException {

• sbp/demo-app/src/test/java/demo/sbp/app/PluginIntegrationTest.java

  Line 247 in d14a98f

  public void loadResourceFromPluginOnly() throws IOException {

[j-barata]

Thanks for your answer.

The idea was to expose the plugins resources from the application, through the standard WebMvcConfigurer interface.
But when I set the @EnableWebMvc annotation on the application class I get the following error :

java.lang.ClassCastException: class org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping cannot be cast to class org.laxture.sbp.internal.PluginRequestMappingHandlerMapping (org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping and org.laxture.sbp.internal.PluginRequestMappingHandlerMapping are in unnamed module of loader 'app')

[hank-cp]

static resource handing is added.

Please check out this test case for details:

• sbp/demo-app/src/test/java/demo/sbp/app/PluginIntegrationTest.java

  Line 454 in 31614cf

  public void testResourceHandler() throws Exception {

this feature is available at v0.1.6 and SNAPSHOOT.

[j-barata]

Hi,
Thank you very much for this (very) quick enhancement !

I'm trying to download the new version from maven central but it doesn't seem to be published yet (I tried with 0.1.6 v0.1.6 -SNAPSHOT -SNAPSHOOT but it doesn't know this version).

Here is my maven configuration:

    <dependency>
        <groupId>org.laxture</groupId>
        <artifactId>sbp-spring-boot-starter</artifactId>
        <version>0.1.6</version>
    </dependency>

[hank-cp]

sorry, fotget to publish...should be available now.

You could also use SNAPSHOT version that always map to latest of matser.

    <dependency>
        <groupId>org.laxture</groupId>
        <artifactId>sbp-spring-boot-starter</artifactId>
        <version>-SNAPSHOT</version>
    </dependency>

[j-barata]

Thanks, I was able to download the new version.

When I tried the new feature, I got the following messages :

Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'resourceHandlerRegistrationCustomizer': Unsatisfied dependency expressed through field 'resourceProperties'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.springframework.boot.autoconfigure.web.ResourceProperties' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}

Field resourceProperties in org.springframework.boot.autoconfigure.web.servlet.PluginResourceHandlerRegistrationCustomizer required a bean of type 'org.springframework.boot.autoconfigure.web.ResourceProperties' that could not be found.

From what I've seen in your recent changes, I can't guess what I could have missed (I basically only added some new configurations in the application.yml).

I tried both development and deployment modes and the result is the same.
I also tried both 2.2.0.RELEASE (SBP's spring boot version) and 2.3.1.RELEASE (my sample project's spring boot version) and the result is the same.

[hank-cp]

I should have explained this supports a little bit more...

Sbp supports resource handling based on Spring Boots' WebMvcAutoConfiguration. So you will need the almost same configurations as enabling resource handling as Spring Boots do, that will be:

spring:
  mvc:
    static-path-pattern: /public/**
  resources:
    add-mappings: true
    cache:
      period: 3600

full version here: https://github.com/hank-cp/sbp/blob/31614cf79ce3c25ac06f5dfe118469894aa1fffb/demo-app/src/main/resources/application.yml

[j-barata]

Hello,
I switched to version 0.1.7 and it works fine !

Thanks a lot for your support.

[DobrolubovaJane]

Hi @j-barata ! I have the same problem when Spring Bootstrap try to createController

java.lang.ClassCastException: class org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerMapping cannot be cast to class org.laxture.sbp.internal.PluginRequestMappingHandlerMapping

What should I do to fix it?

[j-barata]

Hi @DobrolubovaJane

All you have to do is to switch to 0.1.7 version (or upper) and to set this configuration in your "application.yml" :

spring:
mvc:
static-path-pattern: /public/**
resources:
add-mappings: true
cache:
period: 3600

You can also have a look at this sample project : https://github.com/j-barata/marketbasket-sbp-sample