Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FutureWarnings #98

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Fix FutureWarnings #98

merged 6 commits into from
Jul 30, 2024

Conversation

hanjinliu
Copy link
Owner

edge_* will be renamed to border_* in napari. This PR renames all the relevant attributes to silence FutureWarnings.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (ee305fe) to head (fbcdaed).

Files Patch % Lines
cylindra/_napari/_layers.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   83.82%   83.99%   +0.17%     
==========================================
  Files         106      106              
  Lines       14988    14980       -8     
  Branches     3171     3171              
==========================================
+ Hits        12563    12582      +19     
+ Misses       1593     1563      -30     
- Partials      832      835       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanjinliu hanjinliu merged commit 8778f65 into main Jul 30, 2024
24 checks passed
@hanjinliu hanjinliu deleted the edge-to-border branch July 30, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant