Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rise angle null values of calculate_lattice_structure #117

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

hanjinliu
Copy link
Owner

Some of the molecules were wrongly labeled with nan. This PR fix this bug.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (8efea5c) to head (4b67e25).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files         106      106           
  Lines       15053    15053           
  Branches     3194     3194           
=======================================
  Hits        12812    12812           
  Misses       1401     1401           
  Partials      840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanjinliu hanjinliu merged commit d6a8bfa into main Sep 5, 2024
24 checks passed
@hanjinliu hanjinliu deleted the rise-angle branch September 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant