Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some CLI #110

Merged
merged 2 commits into from
Aug 24, 2024
Merged

fix some CLI #110

merged 2 commits into from
Aug 24, 2024

Conversation

hanjinliu
Copy link
Owner

Some command simply did not work.
This PR fixes them and adds more tests.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (fa716c0) to head (da10acf).
Report is 3 commits behind head on main.

Files Patch % Lines
cylindra/cli/run.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   84.59%   85.03%   +0.44%     
==========================================
  Files         104      106       +2     
  Lines       14939    14952      +13     
  Branches     3171     3173       +2     
==========================================
+ Hits        12638    12715      +77     
+ Misses       1474     1401      -73     
- Partials      827      836       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanjinliu hanjinliu merged commit a258f41 into main Aug 24, 2024
23 of 24 checks passed
@hanjinliu hanjinliu deleted the fix-run branch August 24, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant