-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load Xenium clustering into h5ad file #74
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## dev #74 +/- ##
==========================================
- Coverage 37.17% 37.01% -0.17%
==========================================
Files 14 14
Lines 694 697 +3
==========================================
Hits 258 258
- Misses 436 439 +3
☔ View full report in Codecov by Sentry. |
looks like an doc action deployment issue? |
The reason the deploy action fails is because you're merging from a fork of the repo, not a branch - so you don't have permission to deploy to the docs from your forked repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar enough with this Xenium code to approve. Is this a blocker for submission @BioinfoTongLI? Does the cluster need to be reindexed like this? @dannda can you review please?
not really. Especially you said that the 10x Xenium dataset is working well with the current version. We can come back to this after biorXiv submission |
added reindexing step to process_spaceranger.py for loading clusters and embeddings
Current version was not loading embeddings and clusters so we do need to merge this. |
No description provided.