Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load Xenium clustering into h5ad file #74

Merged
merged 6 commits into from
May 18, 2023
Merged

Conversation

BioinfoTongLI
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.17 ⚠️

Comparison is base (fe507fd) 37.17% compared to head (edd0c02) 37.01%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #74      +/-   ##
==========================================
- Coverage   37.17%   37.01%   -0.17%     
==========================================
  Files          14       14              
  Lines         694      697       +3     
==========================================
  Hits          258      258              
- Misses        436      439       +3     
Impacted Files Coverage Δ
bin/build_config.py 0.00% <ø> (ø)
bin/process_xenium.py 32.65% <0.00%> (-2.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BioinfoTongLI
Copy link
Collaborator Author

looks like an doc action deployment issue?

@davehorsfall
Copy link
Member

The reason the deploy action fails is because you're merging from a fork of the repo, not a branch - so you don't have permission to deploy to the docs from your forked repo.

Copy link
Member

@davehorsfall davehorsfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with this Xenium code to approve. Is this a blocker for submission @BioinfoTongLI? Does the cluster need to be reindexed like this? @dannda can you review please?

@davehorsfall davehorsfall requested a review from dannda May 17, 2023 18:57
@BioinfoTongLI
Copy link
Collaborator Author

not really. Especially you said that the 10x Xenium dataset is working well with the current version. We can come back to this after biorXiv submission

added reindexing step to process_spaceranger.py for loading clusters and embeddings
@dannda
Copy link
Collaborator

dannda commented May 18, 2023

Current version was not loading embeddings and clusters so we do need to merge this.
I've dded logic similar to processing spaceranger to load all clusters and embeddings.

@dannda dannda merged commit 18e9d7e into haniffalab:dev May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants