Changed whitespace regex -> /s+. #877
Conversation
|
Is their plans to more actively maintain this repository now woj is not doing it? As woj was very fast with feedback and PR's/issues. Because we have branches/PR's that are becoming backlogged off each other and maintaining them will be a pain if stuff is not getting merged or feedback given as this is a tiny PR... If not then I think we will just develop in our own repo instead and not try and keep in sync with this main repo. |
|
I am sorry to have disappointed you by not reviewing your PR within a few days. The project is actively maintained within our capacity and roadmap. We will be happy to review this when we come to it. |
|
We have assigned a developer to work on accepting your PR and fixing other bugs starting from February. |
|
According to the Contributing guide we need the PR author to approve the CLA at https://docs.google.com/forms/d/e/1FAIpQLScpMq4swMelvw3-onxC8Jl29m0fVp5hpf7d1yQVklqVjGjWGA/viewform?c=0&w=1. @MartinDawson could you please do that so that we can proceed with your PRs? |
|
@MartinDawson I want to merge your PR. Could you resolve the conflicts, please? |
sequba
changed the base branch from
develop
to
feature/issue-898/resolve-conflicts
sequba
changed the base branch from
feature/issue-898/resolve-conflicts
to
develop
sequba
changed the base branch from
develop
to
feature/issue-898/resolve-conflicts
sequba
force-pushed
the
feature/issue-898/resolve-conflicts
branch
from
03954c1
to
40b9578
Compare
|
These changes have been merged into |
…eWhiteSpace) * Changed whitespace regex to `/s+` (#877) * Changed whitespace regex -> /s+. * updated CHANGELOG.MD * Add test for unparsing non-break space character * Introduce config param ignoreWhiteSpace * Fix eslint warning * Change the config parameter ignoreWhiteSpace from boolean to 'standard' | 'any' Co-authored-by: Martin Alex Philip Dawson <u1356770@gmail.com>
|
Hi @MartinDawson I'm the lucky one to announce that the proposed changes, further developed by @sequba and merged to Here #964 is the full list of changes for HyperFormula v2. |
Context
A crazy bug I just ran into caused by this.
In our spreadsheet we use a contentEditable div. We parse the text using chevrotain's lexer to find the cells to highlight. Like so:
When we access the content using
.textContentit seems to replace all spaces with non-breaking spaces.This should be fine because hyperformula should replace ANY space. However it's missing non-breaking spaces from the regex:
pattern: /[ \t\n\r]+/Hyperformula's lexer was returning
#ERROR!due to this.So it should be
/s+instead.How has this been tested?
See the spec test.
Types of changes
Checklist: