Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup & reference functions #520

Merged
merged 23 commits into from
Sep 29, 2020
Merged

Conversation

voodoo11
Copy link
Collaborator

@voodoo11 voodoo11 commented Sep 19, 2020

Context

New functions: HLOOKUP, ROW, COLUMN

Functions VLOOKUP, INDEX, MATCH have been rewritten.
It should eliminate multiple issues with other products compatibility, especially #526, #528

Function UNIQUE seems out of our scope for now as it returns array.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Add Lookup and Reference functions #158
  2. first argument of VLOOKUP is not coerced from null #526
  3. VLOOKUP overwrites errors when coerced #528
  4. HLOOKUP is missing #530
  5. #REF BUG not all dependencies are refresehd after adding a new sheet #493
  6. VLOOKUP #ref error #525

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@voodoo11 voodoo11 marked this pull request as ready for review September 25, 2020 09:58
CHANGELOG.md Outdated Show resolved Hide resolved
src/interpreter/plugin/InformationPlugin.ts Outdated Show resolved Hide resolved
@voodoo11
Copy link
Collaborator Author

voodoo11 commented Sep 25, 2020

@wojciechczerniak Additionally my propose is to change name of vlookupThreshold config parameter to binarySearchThreshold as it is used by VLOOKUP, HLOOKUP and MATCH. It will be also more meaningful. I will include it in this MR if you are fine with it.

Co-authored-by: Przemysław Uznański <40573492+izulin@users.noreply.github.com>
@wojciechczerniak
Copy link
Contributor

@wojciechczerniak Additionally my propose is to change name of vlookupThreshold config parameter to binarySearchThreshold as it is used by VLOOKUP, HLOOKUP and MATCH. It will be also more meaningful. I will include it in this MR if you are fine with it.

Sounds good to introduce binarySearchThreshold 👍 May we keep vlookupThreshold with @deprecated tag and rewrite the option to new binarySearchThreshold on init? Ideally with console.warn("vlookupThreshold option is deprecated since v0.3.0, please use binarySearchThreshold") if someone is using it and should migrate to a new one. @scarletfog we would then change all refrences in the docs to binarySearchThreshold leaving it only in API reference as @deprecated

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@voodoo11 voodoo11 merged commit 4fc2c81 into develop Sep 29, 2020
@voodoo11 voodoo11 deleted the jk/lookup-reference-functions branch September 29, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants