Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IFS function (Issue 1157) #1270

Merged
merged 3 commits into from
May 24, 2023

Conversation

thilgen
Copy link
Contributor

@thilgen thilgen commented May 15, 2023

Context

Add support for the IFS function - a standard formula provided by

For more information

How did you test your changes?

npm run test
> TOTAL: 9564 SUCCESS
npm run lint
> 0 errors and 2043 warnings potentially fixable with the `--fix` option.
npm run test:coverage

--------------------|---------|----------|---------|---------|---------------------
File                | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s   
--------------------|---------|----------|---------|---------|---------------------
BooleanPlugin.ts    |     100 |      100 |     100 |     100 |                     

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Function IFS #1157

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • [N/A] My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@thilgen thilgen mentioned this pull request May 16, 2023
12 tasks
@thilgen thilgen changed the title Add IFS function (Issue 1157) #1269 Add IFS function (Issue 1157) May 16, 2023
@AMBudnik AMBudnik added the CLA signed Required for PR label May 16, 2023
@AMBudnik
Copy link
Contributor

Thank you for sharing a pull request with a new function. We'll review it as soon as possible.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1270 (c29de49) into develop (6911728) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1270      +/-   ##
===========================================
+ Coverage    97.19%   97.20%   +0.01%     
===========================================
  Files          166      167       +1     
  Lines        14243    14297      +54     
  Branches      2966     2988      +22     
===========================================
+ Hits         13843    13897      +54     
  Misses         400      400              
Impacted Files Coverage Δ
src/i18n/languages/csCZ.ts 100.00% <ø> (ø)
src/i18n/languages/daDK.ts 100.00% <ø> (ø)
src/i18n/languages/deDE.ts 100.00% <ø> (ø)
src/i18n/languages/enGB.ts 100.00% <ø> (ø)
src/i18n/languages/esES.ts 100.00% <ø> (ø)
src/i18n/languages/fiFI.ts 100.00% <ø> (ø)
src/i18n/languages/frFR.ts 100.00% <ø> (ø)
src/i18n/languages/huHU.ts 100.00% <ø> (ø)
src/i18n/languages/itIT.ts 100.00% <ø> (ø)
src/i18n/languages/nbNO.ts 100.00% <ø> (ø)
... and 10 more

@sequba sequba changed the base branch from develop to feature/issue-1157 May 24, 2023 09:15
@sequba
Copy link
Contributor

sequba commented May 24, 2023

Thank you @thilgen. I'll merge it to a feature branch first to make a few minor adjustments ;)

@sequba sequba merged commit 5924a88 into handsontable:feature/issue-1157 May 24, 2023
@sequba sequba mentioned this pull request May 24, 2023
13 tasks
sequba added a commit that referenced this pull request May 24, 2023
* IFS function (#1270)

add IFS function

Co-authored-by: Kuba Sekowski <jakub.sekowski@handsontable.com>

* Improve IFS description in the built-in-functions guide

* Improve argument number validation for IFS function

* Return better error message if none of the conditions were met

* Add a docstring to the implementation of IFS

---------

Co-authored-by: Chris Thilgen <thilgen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed Required for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants