-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HYPERLINK (hyperformula) #1216
Conversation
- prev impl did not work for any params to HYPERLINK that were not strings - was also not a way that i could find to re parse the args from the Ast - so stuffing the hyperlink into the FormulaCellVertex seemed to be the next best option
@thilgen Thank you very much for your involvement in the project. We need to focus on the scope of the upcoming release, and currently, we have no capacity to review your pull request. I can assure you that we will check it out as soon as we can. |
TBD: Keyboard bindings, context menu, and docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thilgen thank you. It wasn't clear to me, how to implement HYPERLINK
in a headless engine but I like your solution.
…nto hyperlink-formula
- To protect against batch operations
Codecov Report
@@ Coverage Diff @@
## develop #1216 +/- ##
========================================
Coverage 97.18% 97.19%
========================================
Files 165 166 +1
Lines 14218 14238 +20
Branches 2961 2965 +4
========================================
+ Hits 13818 13838 +20
Misses 400 400
|
Context
HYPERLINK is a formula provided by Google Sheets (documentation); MS Excel (documentation); and is included in the Open Document Format for Office Applications (documentation)
For more information
Handsontable
Changes: Add support for HYPERLINK (handsontable) handsontable#10314How has this been tested?
Unit Tests (100% coverage for new files and new paths*) and Test Application
HyperFormula.ts
which has too many missing paths to determine new impacts.Will try and start looking at increasing coverage for this file in the future so it does not become completely ignorable for codecov stats.Code Coverage: Improve coverage for HyperFormula.ts (92.38% -> 99.65%) #1218Types of changes
Related issues:
Checklist: