Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(function): add MINIFS and MAXIFS #1047

Merged

Conversation

rkretzschmar
Copy link
Contributor

@rkretzschmar rkretzschmar commented Aug 13, 2022

Context

  • adds two not implemented functions MINIFS and MAXIFS to the built-in functions
  • adds only English and German translations, all other language files contain the English translation to pass the i18n.spec.ts
  • describes the two new functions in the built-in-functions.md

How has this been tested?

  • added two new test suites function-minifs.spec.ts and function-maxifs.spec.ts

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature or improvement (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Additional language file or change to the existing one (translations)
  • Change to the documentation

Related issues:

none

Checklist:

  • My code follows the code style of this project.
  • I described the modification in the CHANGELOG.md file.
  • My change requires a change to the documentation.
  • My change requires a migration guide.

@rkretzschmar rkretzschmar marked this pull request as draft August 13, 2022 17:46
@rkretzschmar rkretzschmar marked this pull request as ready for review August 13, 2022 18:13
@sequba sequba added Feature Something we can add later on without introducing a breaking change CLA signed Required for PR Function Feature or bug in formula function labels Aug 16, 2022
@sequba
Copy link
Contributor

sequba commented Aug 16, 2022

Hi @rkretzschmar! Thank you very much for your contribution and for signing the Contributor License Agreement. We'll review the pull request shortly.

@sequba sequba self-assigned this Aug 19, 2022
@sequba
Copy link
Contributor

sequba commented Aug 19, 2022

@rkretzschmar We will try to fit this into the upcoming release.

@rkretzschmar
Copy link
Contributor Author

rkretzschmar commented Aug 19, 2022

@rkretzschmar We will try to fit this into the upcoming release.

Great, let me know if I can help. I am happy with refactoring the whole thing if necessary

@sequba sequba changed the base branch from develop to feature/issue-1049 August 22, 2022 14:31
@sequba
Copy link
Contributor

sequba commented Aug 22, 2022

Great, let me know if I can help. I am happy with refactoring the whole thing if necessary

@rkretzschmar Thanks a lot. I reviewed the code. You did a great job. I love the tests. I'll take care of all the details myself in #1050

@sequba sequba merged commit 63f3ec7 into handsontable:feature/issue-1049 Aug 22, 2022
@sequba sequba mentioned this pull request Aug 22, 2022
20 tasks
@AMBudnik
Copy link
Contributor

AMBudnik commented Sep 8, 2022

Hi @rkretzschmar I'm just here to share the great news, @sequba just released a new version of HyperFormula with your feature merged

@sequba sequba mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed Required for PR Feature Something we can add later on without introducing a breaking change Function Feature or bug in formula function Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants