Hidden dependency on assert package

[wojciechczerniak]

Description

Two files are importing assert package, which is not listed as our dependency. The build will fail in Webpack 5.

hyperformula/src/DependencyGraph/DependencyGraph.ts

Line 6 in 7ff3ab7

import assert from 'assert'

hyperformula/src/interpreter/plugin/NumericAggregationPlugin.ts

Line 6 in 7ff3ab7

import assert from 'assert'

As the use of this dependency is limited to two lines:

hyperformula/src/DependencyGraph/DependencyGraph.ts

Lines 159 to 161 in 7ff3ab7

	public ensureThatVertexIsNonMatrixCellVertex(vertex: CellVertex | null) {
	assert.ok(!(vertex instanceof MatrixVertex), 'Illegal operation')
	}

hyperformula/src/interpreter/plugin/NumericAggregationPlugin.ts

Lines 547 to 550 in 7ff3ab7

	const rangeVertex = this.dependencyGraph.getRange(rangeStart, rangeEnd)!
	assert.ok(rangeVertex, 'Range does not exists in graph')
	let value = rangeVertex.getFunctionValue(functionName) as (T | CellError)

I suggest to replace it with simpler if checks and remove it completely from the code base.

Your environment

• HyperFormula version: 0.6.0
• Browser Name and version: any
• Operating System: any

Links

[wojciechczerniak]

Done in #676