Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be cross browser on modern desktop browsers #2

Closed
warpech opened this issue Jun 15, 2011 · 5 comments
Closed

Should be cross browser on modern desktop browsers #2

warpech opened this issue Jun 15, 2011 · 5 comments
Labels
Docs: Content Issues related to Handsontable's documentation content Status: Released
Milestone
0.1.1

Comments

@warpech
Copy link
Member

warpech commented Jun 15, 2011

Currently it works 100% in Chrome, 90% in Firefox and breaks up in IE8

Should work well in Chrome, Firefox, IE8. Later it should be also proved to work in IE9, Opera and Safari.
@hank511
Copy link

hank511 commented Apr 17, 2012

Your Plugin is awesomme,I want to use this plugin in my project for uploading excel data.Is this plugin now works well on IE now?

@warpech
Copy link
Member Author

warpech commented Apr 17, 2012

I have just checked the browsers I have on hand (Chrome 18, Firefox 11, IE9, IE9 as IE8) and it works 100% in those browsers. Please note that I use it daily only in Chrome and Firefox.

I will not close this ticket until I create some wiki page with a test sheet.

Did you experience some problems with the plugin in IE? If you want to make it working in other browsers, I encourage you to fork.

@hank511
Copy link

hank511 commented Apr 17, 2012

Because I'm living in China! Most people are using IE6, I have test it on IE6.actuallyIt just has some display problem when I select any cells. It display the shadow which cover the data partly So I want to use IE-Hacks to fix this problem.

@warpech
Copy link
Member Author

warpech commented Apr 17, 2012

IE6 should work better now. Please check again and let me know your thoughts about it

@hank511
Copy link

hank511 commented Apr 18, 2012

Thanks for your work ! It works fine now !

@warpech warpech closed this as completed May 13, 2012
@mariotacke mariotacke mentioned this issue Sep 2, 2013
Closed
jasoncrawford added a commit to jasoncrawford/jquery-handsontable that referenced this issue Jul 29, 2014
@jasoncrawford
Merge pull request handsontable#2 from benbernard/fieldbook
efc3363 
More skip redraw cases
@1619digital 1619digital mentioned this issue Apr 7, 2015
Closed
@aurelialeo aurelialeo mentioned this issue Aug 4, 2015
Closed
@frontyard frontyard mentioned this issue Oct 8, 2015
Closed
zhouxiaoping pushed a commit to zhouxiaoping/handsontable that referenced this issue Oct 22, 2015
@pingyuanChen
Merge pull request handsontable#2 from pingyuanChen/py-fix-custom-border
d13e498 
bug fixing for custom borders
@ltoews ltoews mentioned this issue Feb 23, 2016
Closed
@stanleyxu2005 stanleyxu2005 mentioned this issue Sep 21, 2016
Closed
jdmcnair pushed a commit to surgeforward/handsontable that referenced this issue Sep 9, 2017
fixing linting errors making Jenkins sad - pass handsontable#2
2e2ff54
@AMBudnik AMBudnik added Docs: Content Issues related to Handsontable's documentation content Status: Released labels Mar 30, 2018
budnix pushed a commit that referenced this issue Nov 27, 2018
@jansiegel
Implement allowSplitWeeks option for the Gantt Chart plugin. #2
5529203
budnix pushed a commit that referenced this issue Nov 27, 2018
@jansiegel
Code cleanup. #2
6e31531
budnix pushed a commit that referenced this issue Nov 27, 2018
@jansiegel
Code cleanup #2
c08a0be
budnix pushed a commit that referenced this issue Nov 27, 2018
@jansiegel
Code cleanup. #2
50b8787
@DongShi DongShi mentioned this issue Jan 9, 2019
Closed
warpech added a commit that referenced this issue Aug 29, 2019
@warpech @swistach
Coding style improvements #2
e7b90fc 
as suggested by @swistach in the review #6200 (review)

Co-Authored-By: Piotr Laszczkowski <swistach@users.noreply.github.com>
@d-yh d-yh mentioned this issue Sep 4, 2019
Closed
warpech added a commit that referenced this issue Sep 6, 2019
@warpech @swistach
WOT Table return correct information in the overlay (#6200)
d6a5be6 
* fix "getLastRenderedRow"  to check the relevant method

it seems a bug in the tests that these two tests were actually checking "getFirstRenderedRow"

it seems strange that one assertion scrolls to make row 10 visible, and then checks that last rendered row is 11, but this is the current behavior so be it

* change "getLastRenderedRow", "isRowAfterRenderedRows" to respond in context of the overlay #6191

* amend last: test all overlays

* change "getLastVisibleRow", to respond in context of the overlay #6191

* refactor: use polymorphism to adjust Table behavior for overlays

* amend last: change two methods to be no-ops in overlays

* refactor: split "getRenderedRowsCount" into overlay table variants and add test

* refactor: split "getRenderedColumnsCount" into overlay table variants and add test

* refactor: unify ways of checking the type of overlay

* refactor: simplify "isOverlay" logic

* change "getVisibleRowsCount", to respond in context of the overlay #6191

* change "getVisibleColumnsCount", to respond in context of the overlay #6191

* bugfix: "getLastReneredRow" should take into account that the number of actual total rows is smaller than "fixedRowsTop" setting

* refactor: consistently use "this.wot" over "this.instance"

* change "getLastRenderedColumn", to respond in context of the overlay #6191

* change "getLastVisibleColumn", to respond in context of the overlay #6191

* change "getFirstRenderedRow", to respond in context of the overlay #6191

* change "getFirstVisibleRow", to respond in context of the overlay #6191

* change "getFirstRenderedColumn", to respond in context of the overlay #6191

* change "getFirstVisibleColumn", to respond in context of the overlay #6191

* change "isBeforeRenderedRows", to respond in context of the overlay #6191

* add tests for "isRowAfterViewport"

* add tests for "isRowAfterRenderedRows"

* bugfix: return value was incorrectly offsetted

* safeguard: add assertion that TR and TD was found

* refactor: use existing helper function to determine the starting row and column

* refactor: never use Table class directly

in case of "not overlay", instantiate MasterTable

* refactor: move code used by one or more Table classes to a mixin

* apend refactor: move code used by one or more Table classes to a mixin (columns)

* code style: white space and typo improvements

as suggested and explained in:
- #6200 (comment)
- #6200 (comment)

* refactor: move two methods to MasterTable

move methods `alignOverlaysWithTrimmingContainer`, `markOversizedColumnHeaders` to MasterTable,
because they were no-ops in other (overlay) tables

* fix implementation and tests of getCell and related functions

fix implementation and tests of getCell the methods:
- getCell
- isRowBeforeRenderedRows
- isRowAfterRenderedRows
- isColumnBeforeRenderedColumns
- isColumnAfterRenderedColumns

to match the expectation that this methods should work on row & column headers when given a negative index. This is to address the comment #6200 (review)

* make sure helper functions return -1 in case there is no rows/columns in any given overlay

affects functions:
- getFirstRenderedRow()
- getFirstVisibleRow()
- getLastRenderedRow()
- getLastVisibleRow()

to address comment #6200 (review)

* fix failing tests

fix few places in code that were expecting null value instead of -1 returned from getFirstRenderedRow, getFirstVisibleRow, getFirstRenderedColumn, getFirstVisibleColumn

* remove redundant class

remove redundant subclass/superclass OverlayTable, which was common for all subclasses of Table which are not MasterTable. This class not used anywhere. Removing because it is YAGNI

* add missing JSDoc

* Coding style improvements

as suggested by @swistach in the review #6200 (review)

Co-Authored-By: Piotr Laszczkowski <swistach@users.noreply.github.com>

* Coding style improvements #2

as suggested by @swistach in the review #6200 (review)

Co-Authored-By: Piotr Laszczkowski <swistach@users.noreply.github.com>

* Coding style improvements #3

as suggested by @swistach in the review #6200 (review)

* use async/await sleep instead of setTimeout

as suggested by @swistach in the review #6200 (review)

* refactor: use instance.getCell to get a TD

because that is the most DRY way to get the cell for a relevant overlay, as suggested in #6200 (comment).

This change breaks backwards compat by returning "null" instead of "undefined" when the TD is not found. I find this safe to do because, as is no test for it and no documentation anyway.

* improve JSDoc

because it was missing information about the order of validation of the input parameters, as pointed out in #6200 (comment)

* code cleanup: put helper methods on top of the file

because they are or might be used multiple times

* add missing test for using hot.getCell with Nested Headers

this test checks that the first nested header row has index -1, the next one is -2, etc. The discussion about the desired order is here: #6200 (comment)

* change the implementation of negative row index in getCell

now, with nested headers, "-1" means the inner header and "-<countHeaders>" means the outmost header

as requested in #6200 (comment)

* refactor: simplify and document how the function behaves for negative indexes

as pointed out in #6200 (comment)

* bugfix: the role of negative indexes was changed

the role of negative indexes was changed in the commit 07aef23, but I forgot to make analogous fix in `isRowAfterRenderedRow` and `isColumnAfterRenderedColumns`. This is my attempt to fix that.

* fix typo in JSDoc

Co-Authored-By: Piotr Laszczkowski <swistach@users.noreply.github.com>
@Siemienik Siemienik mentioned this issue Aug 2, 2021
Closed
@adrianszymanski89 adrianszymanski89 mentioned this issue May 26, 2022
Closed
budnix added a commit that referenced this issue Jul 13, 2022
@budnix
Merge pull request #2 from budnix/feature/docs-change1
45579af 
Content change test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs: Content Issues related to Handsontable's documentation content Status: Released
Projects
None yet
Milestone
0.1.1
Development

No branches or pull requests
3 participants
@warpech @hank511 @AMBudnik