fix: 修复map组件中心经纬度负数异常和scale非法值异常 #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangcq-code
reviewed
Dec 4, 2023
| @@ -164,7 +164,7 @@ export default class PageView extends React.Component { | |||
| } | |||
|
|
|||
| handleClickLatitude = async () => { | |||
| const latitude = /^\d+(\.\d+)?$/.test(this.state.lat) ? this.state.lat : '' | |||
| const latitude = /^-?\d+(\.\d+)?$/.test(this.state.lat.toString()) || this.state.lat === 0 ? this.state.lat : '' | |||
| @@ -182,7 +182,7 @@ export default class PageView extends React.Component { | |||
| } | |||
|
|
|||
| handleClickLongitude = async () => { | |||
| const longitude = /^\d+(\.\d+)?$/.test(this.state.lng) ? this.state.lng : '' | |||
| const longitude = /^-?\d+(\.\d+)?$/.test(this.state.lng.toString()) || this.state.lng === 0 ? this.state.lng : '' | |||
tangcq-code
approved these changes
Dec 5, 2023
…g/taro into release-3.6.8-app
tangcq-code
merged commit e9cf89b
into
handsomeliuyang:release-3.6.8-app
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
fix: 修复map组件中心经纬度负数异常和scale非法值异常
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: