Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm warning #776

Merged
merged 6 commits into from
Nov 11, 2022
Merged

Fix npm warning #776

merged 6 commits into from
Nov 11, 2022

Conversation

NetOpWibby
Copy link
Contributor

@NetOpWibby NetOpWibby commented Nov 2, 2022

Apparently, --omit=dev should be used over --production.

Apparently, `--omit-dev` should be used over `--production`.
Copy link
Contributor

@rtdev-com rtdev-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix a typo

Co-authored-by: Roma <81729714+rtdev-com@users.noreply.github.com>
@pinheadmz
Copy link
Member

grep the repo for production, there are two more places to change I think: Dockerfile and CONTRIBUTING.md can you find anything else like this that needs to be updated?

@NetOpWibby
Copy link
Contributor Author

grep -irn "\-\-production" shows:

./Dockerfile:9:RUN npm install --production
./docs/install.md:36:npm install --production
./CONTRIBUTING.md:23:"developer dependency" if installed without the `--production` flag. The

@NetOpWibby
Copy link
Contributor Author

@pinheadmz All set!

@pinheadmz
Copy link
Member

CI was failing on node v12 which is unsupported now anyway. Removing that so this docs-only PR will pass integration tests!

@pinheadmz
Copy link
Member

Ugh, @chjj's DNS seed server is down. I'm gonna fix this flakey test by targeting nic.com a much more reliable name for lookups.

@coveralls
Copy link

coveralls commented Nov 11, 2022

Coverage Status

Coverage decreased (-0.2%) to 67.744% when pulling 8f062c3 on NetOpWibby:patch-1 into 395878a on handshake-org:master.

@pinheadmz
Copy link
Member

Ugh part III: Fine lets just skip the test that requires external DNS lookups, for now.

@pinheadmz pinheadmz merged commit 9cf8cb8 into handshake-org:master Nov 11, 2022
@NetOpWibby NetOpWibby deleted the patch-1 branch November 11, 2022 18:17
handshake-enthusiast added a commit to handshake-enthusiast/hsd that referenced this pull request Jan 4, 2023
@nodech nodech mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants