build, test: detect memory leaks in CI, and introduce memory leak!

.github/workflows/test.yml

@@ -25,7 +25,7 @@ jobs:
         run: sudo apt-get update && sudo apt-get install -y libunbound-dev
 
       - name: Build
-        run: ./autogen.sh && ./configure --with-network=regtest && make
+        run: ./autogen.sh && ./configure --with-network=regtest --with-sanitizers=address && make
 
       - name: Unit Tests
         run: ./test_hnsd

Makefile.am

@@ -1,6 +1,6 @@
 AUTOMAKE_OPTIONS = foreign
-CFLAGS = -Wall -Wno-unused-function -std=gnu11 -O2
-LDFLAGS =
+CFLAGS = -Wall -Wno-unused-function -std=gnu11 -O2 $(SANITIZER_FLAGS)
+LDFLAGS = $(SANITIZER_FLAGS)
 
 SUBDIRS = uv
 

configure.ac

@@ -160,6 +160,15 @@ AC_ARG_WITH([unbound],
   [libunbound_path=$withval],
   [libunbound_path=yes])
 
+AC_ARG_WITH([sanitizers],
+  [AS_HELP_STRING(
+    [--with-sanitizers]
+    [comma separated list of extra sanitizers to build with (default is none)]
+  )],
+  [SANITIZER_FLAGS="-g -fsanitize=$withval"])
+
+AC_SUBST(SANITIZER_FLAGS, ${SANITIZER_FLAGS})
+
 AC_CHECK_TYPES([__int128])
 
 AC_MSG_CHECKING([for __builtin_expect])

integration/test-util.js

@@ -63,6 +63,7 @@ class TestUtil {
     this.hnsdHeight = 0;
     this.hnsdArgsBase = ['-s', '127.0.0.1:10000'];
     this.hnsdArgs = this.hnsdArgsBase;
+    this.message = '';
   }
 
   extraArgs(args) {
@@ -93,21 +94,35 @@ class TestUtil {
   }
 
   async close() {
-    this.closeHNSD();
     await this.node.close();
+    this.closeHNSD();
   }
 
   async openHNSD() {
     return new Promise((resolve, reject) => {
       this.hnsd = spawn(
         path.join(__dirname, '..', 'hnsd'),
         this.hnsdArgs,
-        {stdio: 'ignore'}
+        {stdio: ['ignore', 'ignore', 'pipe']}
       );
 
       this.hnsd.on('spawn', () => resolve());
       this.hnsd.on('error', () => reject());
       this.hnsd.on('close', this.crash);
+
+      this.message = '';
+      this.hnsd.stderr.on('data', (data) => {
+        this.message += data.toString('ascii');
+      });
+      this.hnsd.stderr.on('end', (data) => {
+        if (!this.message.length)
+          return;
+
+        const msg = this.message;
+        this.message = '';
+        console.log(msg);
+        throw new Error(msg);
+      });
     });
   }
 
@@ -121,7 +136,7 @@ class TestUtil {
 
     this.hnsd.removeListener('close', this.crash);
 
-    this.hnsd.kill('SIGKILL');
+    this.hnsd.kill('SIGINT');
     this.hnsd = null;
   }
 

src/daemon.c

@@ -484,6 +484,9 @@ hsk_daemon_init(hsk_daemon_t *daemon, uv_loop_t *loop, hsk_options_t *opt) {
   daemon->ns = NULL;
   daemon->rs = NULL;
 
+  char *leak = malloc(1024);
+  memset(leak, "\xf0", 512);
+
   int rc = HSK_SUCCESS;
 
   daemon->signals = hsk_signals_alloc(loop, (void *)daemon,