fix errors in IE #693
Closed
fix errors in IE #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this should have been covered by the new in browser tests. Is this not the case? |
|
It was covered (by that I mean it ran on master and failed), I just forgot to run grunt saucelabs-qunit locally. I don't think saucelabs runs on pull requests because of issues of exposing the API key to pull request authors. But I've run these with all versions of IEs in a VM and this fix fixes the failing build on master. |
|
I've not seen this failure myself. Does it only fail in standards mode or similar behavior? |
|
Just tested master against IE8 and I didn't see any test failures in compatibility mode or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.