Add @first and @last data variables to #each helper #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (data) { | ||
| data.index = i; | ||
| data.first = (i === 0) ? true : false; | ||
| data.last = (i === (context.length-1)) ? true : false; |
There was a problem hiding this comment.
No need to use the ? operator if creating a boolean result.
|
Thanks @kpdecker, I've removed the excess ? operator calls. |
kpdecker
added a commit
that referenced
this pull request
Oct 12, 2013
|
There were a lot of changes on master so I rebased this locally, but that appears to have confused github. Merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for adding @FIRST and @last data variables to the #each helper. The implementation is as described in issue #483 along with basic tests .
@FIRST returns true during the first element of the array, otherwise false.
@last returns true during the last element of the array, otherwise false.
Let me know if you have any feedback,
Thanks,
Dennis