Close issue #597. Fixes the Utils.isEmpty -function #598
Conversation
…from falsy values. The if-helper has to only call this function, not do own check for the conditional.
| @@ -67,14 +67,15 @@ Handlebars.Utils = { | |||
| }, | |||
|
|
|||
| isEmpty: function(value) { | |||
| if (!value && value !== 0) { | |||
| if(typeof value === 'undefined' || value === null || value === false || value === ""){ | |||
There was a problem hiding this comment.
typeof value === 'undefined' || value === null can be written more succinctly as value == null (the double-equals will check for both undefined and null). You can save the typeof check since we don't have to worry about ReferenceErrors.
There was a problem hiding this comment.
Forgive me for being dense, but how does this change the behavior? Isn't this the exact same logic implemented with || to include cases rather than && to exclude cases?
There was a problem hiding this comment.
For that part yes but the problem is in the base.js. I just tried to write that part in the utils.js more readable because using && as excluding case is harder on the eye. I prefer being explicit. Handlebars still considers 0 as a falsy value. Could you please provide comment on that?
There was a problem hiding this comment.
Since it has to go over the wire we prefer smaller code (after minimization) over verbosity. Obviously there is gray room in this as sometimes smaller code is harder to understand but I actually found this implementation harder to understand over "falsy except for zero" as there is more to read.
There was a problem hiding this comment.
Ok. Please refer to pull request #602 which fixes the core problem.
Close issue #597. Fixes the Utils.isEmpty -function to omit 0 (zero) from falsy values. The if-helper has to only call this function, not do own check for the conditional.