Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partialName can now be a property. Fixes #189 #244

Closed
wants to merge 1 commit into from
Closed

partialName can now be a property. Fixes #189 #244

wants to merge 1 commit into from

Conversation

maho2nd
Copy link

@maho2nd maho2nd commented May 21, 2012

if a partial with the specified name could not be found it will handle the name as a property.

@wagenet
Copy link
Collaborator

wagenet commented May 25, 2012

What's the use case for this?

@maho2nd
Copy link
Author

maho2nd commented May 25, 2012

@wagenet For example if you want specify the name of your partial in json data, see #189

@wagenet
Copy link
Collaborator

wagenet commented May 25, 2012

@maho2nd Ok, makes sense. I'd really like tests for this though.

@andriijas
Copy link

Would love to see this merge soon. Thanks

@andriijas
Copy link

@wagenet @wycats any plans on merging? Thanks

@wagenet
Copy link
Collaborator

wagenet commented Jul 31, 2012

We're not likely to merge this without tests.

@casio
Copy link

casio commented Sep 25, 2012

Great!

@wycats
Copy link
Collaborator

wycats commented Oct 13, 2012

I'm closing this for now. If someone submits a pull request with tests, we can reopen the discussion. Thanks!

@wycats wycats closed this Oct 13, 2012
@andriijas
Copy link

No worries. I reorganized my code months ago and solved my problem in better ways. I think there are better paths than allowing dynamic partials in most usecases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants