Simplify BlockNode by removing intermediate MustacheNode

handlebars-lang · Nov 2, 2014 · 7ed6d22 · 7ed6d22
1 parent 3e1840a
commit 7ed6d22
Show file tree

Hide file tree

Showing 6 changed files with 40 additions and 26 deletions.
diff --git a/lib/handlebars/compiler/ast.js b/lib/handlebars/compiler/ast.js
@@ -79,11 +79,11 @@ var AST = {
     this.strip.inlineStandalone = true;
   },
 
-  BlockNode: function(mustache, program, inverse, strip, locInfo) {
+  BlockNode: function(sexpr, program, inverse, strip, locInfo) {
     LocationInfo.call(this, locInfo);
 
     this.type = 'block';
-    this.mustache = mustache;
+    this.sexpr = sexpr;
     this.program  = program;
     this.inverse  = inverse;
     this.strip = strip;
@@ -93,17 +93,11 @@ var AST = {
     }
   },
 
-  RawBlockNode: function(mustache, content, close, locInfo) {
+  RawBlockNode: function(sexpr, content, locInfo) {
     LocationInfo.call(this, locInfo);
 
-    if (mustache.sexpr.id.original !== close) {
-      throw new Exception(mustache.sexpr.id.original + " doesn't match " + close, this);
-    }
-
-    content = new AST.ContentNode(content, locInfo);
-
     this.type = 'block';
-    this.mustache = mustache;
+    this.sexpr = sexpr;
     this.program = new AST.ProgramNode([content], {}, locInfo);
   },
 

diff --git a/lib/handlebars/compiler/compiler.js b/lib/handlebars/compiler/compiler.js
@@ -108,7 +108,7 @@ Compiler.prototype = {
   },
 
   block: function(block) {
-    var mustache = block.mustache,
+    var sexpr = block.sexpr,
         program = block.program,
         inverse = block.inverse;
 
@@ -120,7 +120,6 @@ Compiler.prototype = {
       inverse = this.compileProgram(inverse);
     }
 
-    var sexpr = mustache.sexpr;
     var type = this.classifySexpr(sexpr);
 
     if (type === "helper") {

diff --git a/lib/handlebars/compiler/helpers.js b/lib/handlebars/compiler/helpers.js
@@ -7,17 +7,34 @@ export function stripFlags(open, close) {
   };
 }
 
+export function prepareRawBlock(openRawBlock, content, close, locInfo) {
+  if (openRawBlock.sexpr.id.original !== close) {
+    var errorNode = {
+      firstLine: openRawBlock.sexpr.firstLine,
+      firstColumn: openRawBlock.sexpr.firstColumn
+    };
+
+    throw new Exception(openRawBlock.sexpr.id.original + " doesn't match " + close, errorNode);
+  }
+
+  return new this.RawBlockNode(openRawBlock.sexpr, content, locInfo);
+}
 
-export function prepareBlock(mustache, program, inverseAndProgram, close, inverted, locInfo) {
+export function prepareBlock(openBlock, program, inverseAndProgram, close, inverted, locInfo) {
   /*jshint -W040 */
-  if (mustache.sexpr.id.original !== close.path.original) {
-    throw new Exception(mustache.sexpr.id.original + ' doesn\'t match ' + close.path.original, mustache);
+  if (openBlock.sexpr.id.original !== close.path.original) {
+    var errorNode = {
+      firstLine: openBlock.sexpr.firstLine,
+      firstColumn: openBlock.sexpr.firstColumn
+    };
+
+    throw new Exception(openBlock.sexpr.id.original + ' doesn\'t match ' + close.path.original, errorNode);
   }
 
   var inverse = inverseAndProgram && inverseAndProgram.program;
 
   var strip = {
-    left: mustache.strip.left,
+    left: openBlock.strip.left,
     right: close.strip.right,
 
     // Determine the standalone candiacy. Basically flag our content as being possibly standalone
@@ -26,7 +43,7 @@ export function prepareBlock(mustache, program, inverseAndProgram, close, invert
     closeStandalone: isPrevWhitespace((inverse || program).statements)
   };
 
-  if (mustache.strip.right) {
+  if (openBlock.strip.right) {
     omitRight(program.statements, null, true);
   }
 
@@ -57,9 +74,9 @@ export function prepareBlock(mustache, program, inverseAndProgram, close, invert
   }
 
   if (inverted) {
-    return new this.BlockNode(mustache, inverse, program, strip, locInfo);
+    return new this.BlockNode(openBlock.sexpr, inverse, program, strip, locInfo);
   } else {
-    return new this.BlockNode(mustache, program, inverse, strip, locInfo);
+    return new this.BlockNode(openBlock.sexpr, program, inverse, strip, locInfo);
   }
 }
 

diff --git a/lib/handlebars/compiler/printer.js b/lib/handlebars/compiler/printer.js
@@ -40,7 +40,7 @@ PrintVisitor.prototype.block = function(block) {
 
   out = out + this.pad("BLOCK:");
   this.padding++;
-  out = out + this.accept(block.mustache);
+  out = out + this.accept(block.sexpr);
   if (block.program) {
     out = out + this.pad("PROGRAM:");
     this.padding++;

diff --git a/spec/ast.js b/spec/ast.js
@@ -71,7 +71,7 @@ describe('ast', function() {
     it('should throw on mustache mismatch', function() {
       shouldThrow(function() {
         handlebarsEnv.parse("\n  {{#foo}}{{/bar}}");
-      }, Handlebars.Exception, "foo doesn't match bar - 2:2");
+      }, Handlebars.Exception, "foo doesn't match bar - 2:5");
     });
 
     it('stores location info', function(){

diff --git a/src/handlebars.yy b/src/handlebars.yy
@@ -17,16 +17,20 @@ statement
   | block -> $1
   | rawBlock -> $1
   | partial -> $1
-  | CONTENT -> new yy.ContentNode($1, @$)
+  | content -> $1
   | COMMENT -> new yy.CommentNode($1, @$)
   ;
 
+content
+  : CONTENT -> new yy.ContentNode($1, @$)
+  ;
+
 rawBlock
-  : openRawBlock CONTENT END_RAW_BLOCK -> new yy.RawBlockNode($1, $2, $3, @$)
+  : openRawBlock content END_RAW_BLOCK -> yy.prepareRawBlock($1, $2, $3, @$)
   ;
 
 openRawBlock
-  : OPEN_RAW_BLOCK sexpr CLOSE_RAW_BLOCK -> new yy.MustacheNode($2, null, '', '', @$)
+  : OPEN_RAW_BLOCK sexpr CLOSE_RAW_BLOCK -> { sexpr: $2 }
   ;
 
 block
@@ -35,11 +39,11 @@ block
   ;
 
 openBlock
-  : OPEN_BLOCK sexpr CLOSE -> new yy.MustacheNode($2, null, $1, yy.stripFlags($1, $3), @$)
+  : OPEN_BLOCK sexpr CLOSE -> { sexpr: $2, strip: yy.stripFlags($1, $3) }
   ;
 
 openInverse
-  : OPEN_INVERSE sexpr CLOSE -> new yy.MustacheNode($2, null, $1, yy.stripFlags($1, $3), @$)
+  : OPEN_INVERSE sexpr CLOSE -> { sexpr: $2, strip: yy.stripFlags($1, $3) }
   ;
 
 inverseAndProgram