Elasticsearch 8.x Support #18

hkulekci · 2022-02-27T00:49:22Z

Here is a PR for Elasticsearch 8.x support. You can check my notes from hkulekci#2 this pull request.

bulk changes for phpunit9 deprecation warnings of the test cases

…erval and fixed interval

Elasticsearch 8.0 support

hkulekci · 2022-02-27T00:51:48Z

I think we need to change the base branch of this PR. please notify me if necessary.

hkulekci · 2022-03-02T11:42:20Z

/ping @alexander-schranz

.github/workflows/test-application.yaml

alexander-schranz · 2022-03-02T11:58:18Z

composer.json

        }
    ],
    "require": {
-        "php": "^7.1|^8.0",
+        "php": "^7.4 || ^8.0",
        "symfony/serializer": "^2.8 || ^3.4 || ^4.0 || ^5.0",


You did write that Symfony 4.4 is not longer supported then we should adjust it here.

In fact, I could not be sure about this version matrix. Let me think about it a little bit.

Maybe we can also allow and test against symfony ^6.0

I also need to discuss it internal if we need to support Elasticsearch 8 for Symfony 3.4 because of @sulu ArticleBundle 1.2 Version.

Okay. Let me know the decision of the internal discussion. As I see on my local test, all the versions are working, but I could not test with full Symfony, and I rely on tests.

alexander-schranz

@hkulekci Nice work 👍 , didnt here about it that Elasticsearch 8 is released.

hkulekci · 2022-03-02T13:44:41Z

👍 technology is going fast :D Most of the time we are missing it.

hkulekci · 2022-03-06T06:43:40Z

Before merging this, we need to check the tests again. After dev releases, there are some BC changes on alpha release. https://github.com/elastic/elasticsearch-php/releases/tag/v8.0.0-alpha. Let me check the PR again for BC changes.

hkulekci · 2022-03-06T11:47:51Z

As I see, there are some problems related to the elastic/transport library for the alpha release, and it is not stable to use it yet. But I tested with the 8.x-dev release, and it is working clearly. Our changes will be valid for the stable release, but we need to make other changes related to namespacing when the stable 8.x version is published. I tested with 8.0.0-alpha release, and I got the below errors :

1) ONGR\ElasticsearchDSL\Tests\Functional\Aggregation\DateHistogramAggregationTest::testDateHistogramWithMinuteCalendarInterval
Error: Call to undefined method Elastic\Transport\Transport::setRetries()

/Volumes/webroot/github/ElasticsearchDSL/vendor/elasticsearch/elasticsearch/src/ClientBuilder.php:330
/Volumes/webroot/github/ElasticsearchDSL/tests/Functional/AbstractElasticsearchTestCase.php:38

2) ONGR\ElasticsearchDSL\Tests\Functional\Aggregation\DateHistogramAggregationTest::testDateHistogramWithMonthCalendarInterval
Error: Call to undefined method Elastic\Transport\Transport::setRetries()

/Volumes/webroot/github/ElasticsearchDSL/vendor/elasticsearch/elasticsearch/src/ClientBuilder.php:330
/Volumes/webroot/github/ElasticsearchDSL/tests/Functional/AbstractElasticsearchTestCase.php:38

3) ONGR\ElasticsearchDSL\Tests\Functional\Aggregation\DateHistogramAggregationTest::testDateHistogramWitMinuteFixedInterval
Error: Call to undefined method Elastic\Transport\Transport::setRetries()

/Volumes/webroot/github/ElasticsearchDSL/vendor/elasticsearch/elasticsearch/src/ClientBuilder.php:330
/Volumes/webroot/github/ElasticsearchDSL/tests/Functional/AbstractElasticsearchTestCase.php:38

4) ONGR\ElasticsearchDSL\Tests\Functional\Query\FunctionScoreQueryTest::testRandomScore
Error: Call to undefined method Elastic\Transport\Transport::setRetries()

/Volumes/webroot/github/ElasticsearchDSL/vendor/elasticsearch/elasticsearch/src/ClientBuilder.php:330
/Volumes/webroot/github/ElasticsearchDSL/tests/Functional/AbstractElasticsearchTestCase.php:38

5) ONGR\ElasticsearchDSL\Tests\Functional\Query\FunctionScoreQueryTest::testScriptScore
Error: Call to undefined method Elastic\Transport\Transport::setRetries()

/Volumes/webroot/github/ElasticsearchDSL/vendor/elasticsearch/elasticsearch/src/ClientBuilder.php:330
/Volumes/webroot/github/ElasticsearchDSL/tests/Functional/AbstractElasticsearchTestCase.php:38

6) ONGR\ElasticsearchDSL\Tests\Functional\Query\MatchAllQueryTest::testMatchAll
Error: Call to undefined method Elastic\Transport\Transport::setRetries()

/Volumes/webroot/github/ElasticsearchDSL/vendor/elasticsearch/elasticsearch/src/ClientBuilder.php:330
/Volumes/webroot/github/ElasticsearchDSL/tests/Functional/AbstractElasticsearchTestCase.php:38

ERRORS!
Tests: 255, Assertions: 314, Errors: 6.

These are related to inconsistency between elasticsearch/elasticsearch:8.0.0-alpha and elastic/transport:8.0.0-rc3 libraries.

So, what I am trying to suggest. We can continue with 8.x-dev release for now, and we can do another iteration for stable version support after the stable version is published. We are waiting here to support for ES 8.x in this library.

/ping @alexander-schranz

hkulekci · 2022-03-11T18:59:56Z

Do we have any update here? @alexander-schranz

alexander-schranz · 2022-03-12T17:59:43Z

hello @hkulekci,

These are related to inconsistency between elasticsearch/elasticsearch:8.0.0-alpha and elastic/transport:8.0.0-rc3 libraries.

Looks like they released already some RC releases. for the elasticsearch-php. I think I would wait with merging and tagging a 8.0 release until the final stable version of https://github.com/elastic/elasticsearch-php 8.0 is released. Would that block something on your side?

hkulekci · 2022-03-13T07:37:27Z

@alexander-schranz, I see. I am just an adventurer here ^_^. There is no blocker for me. Some users of https://github.com/matchish/laravel-scout-elasticsearch library request ES8 support and, I start the journey to help the community. As I know, the users have a solution; they can use repository aliasing if anybody wants to use my repository as 8.x. Let's wait for the stable version if anybody has a blocker. Thanks for your time.

alexander-schranz · 2022-03-25T10:01:29Z

Looks like we got a stable release now: https://github.com/elastic/elasticsearch-php/releases/tag/v8.0.0 🎉 do you want to rebase the branch and check if all works like expected?

hkulekci · 2022-03-25T18:52:48Z

Sure. Let me give me some time to check the result.

hkulekci · 2022-03-25T20:11:14Z

I just changed the namespace and executeSearch() method response. I think this is enough.

hkulekci · 2022-03-25T20:19:02Z

The repository trying to fetch v8.x-dev version because of "minimum-stability": "dev" configuration of the composer.json. So, the current tests are failing when I choose the requirement as "elasticsearch/elasticsearch": "^8.0.0". I was try to select a direct version instead of a semantic one as "elasticsearch/elasticsearch": "8.0.0", in this case, we are getting an error because of composer validation composer validate --strict. I think we need to choose one of them. @alexander-schranz

alexander-schranz · 2022-03-25T20:27:04Z

Looks like they created a 8.1 branch which is not up2date with 8.0 changes: elastic/elasticsearch-php#1204

You can could currently go with 8.0.* in the composer.json.

composer.json

alexander-schranz · 2022-03-25T20:45:54Z

To run the tests we need a psr18 client implementation I added the same as elasticsearch is using for there tests.

hkulekci · 2022-03-25T20:46:43Z

I was trying to solve this on another branch on my repository. I think you have already solved it nicely. 👍

hkulekci#3

alexander-schranz · 2022-03-25T20:51:45Z

@hkulekci thank you for all your work. Great Job 👍 I tagged a RC version: https://github.com/handcraftedinthealps/ElasticsearchDSL/releases/tag/8.0.0-RC1

hkulekci · 2022-03-25T20:54:06Z

Hey @alexander-schranz thanks for the patience of this long conversation :) 💯

alexander-schranz · 2022-03-25T20:58:18Z

Was a pleasure to help here and happy for everybody who try to contribute something :)

alexander-schranz · 2022-08-16T16:51:49Z

We tagged a stable 8.0.0 now.

hkulekci and others added 18 commits February 16, 2022 10:04

bulk changes for phpunit9 deprecation warnings of the test cases

df2d7cf

Merge pull request #1 from hkulekci/phpunit-9-warnings-fixed

176c5e7

bulk changes for phpunit9 deprecation warnings of the test cases

composer update and readme changes for elasticsearch 8.0

ef4ebaf

MovingAverage pipeline aggregation removed for ES8.x

6a7af66

Remove deprecated _time and _term sort orders

0675b13

Remove deprecated date histogram interval and changed as calendar_int…

3e5759f

…erval and fixed interval

php 7.1 support droped and the version increased to ^7.4

fce8532

php 7.1, 7.2 and 7.3 remove d from the github ci

c177324

phpcs fix for the changes

08883b4

phpunit upgraged to 9.x

3fba68b

::class used instead of text

19b05eb

Removes typed endpoint from search on tests

6d9a3e2

cutoff_frequency sample removed for CommonTerms query

41b790a

Remove CommonTermsQuery and cutoff_frequency params

edc8829

functional test for date histogram

46c8b52

elasticsearch version increased for the test node

b327422

removed e_user_deprecated exceptions for GeoShape query

e346467

Merge pull request #2 from hkulekci/elasticsearch-8.0-support

cac247d

Elasticsearch 8.0 support

alexander-schranz changed the base branch from 7.x to 8.x March 2, 2022 11:55

alexander-schranz reviewed Mar 2, 2022

View reviewed changes

.github/workflows/test-application.yaml Show resolved Hide resolved

alexander-schranz reviewed Mar 2, 2022

View reviewed changes

alexander-schranz added the enhancement New feature or request label Mar 2, 2022

php8.1 added on test matrix

a77837c

hkulekci mentioned this pull request Mar 6, 2022

ElasticSearch 8.0 support matchish/laravel-scout-elasticsearch#184

Closed

upgrade the version of elasticsearch to 8.0.0

ad88b0f

hkulekci requested a review from alexander-schranz March 25, 2022 20:10

fix for the elasticsearch-php version

9b070a0

alexander-schranz reviewed Mar 25, 2022

View reviewed changes

composer.json Outdated Show resolved Hide resolved

alexander-schranz added 2 commits March 25, 2022 21:39

Update composer.json

2594f11

Add a psr 18 client implementation (nyholm/psr7)

f007749

alexander-schranz merged commit 86e37b5 into handcraftedinthealps:8.x Mar 25, 2022

This was referenced Mar 25, 2022

Add support for handcraftedinthealps/ElasticsearchDSL 8 handcraftedinthealps/ElasticsearchBundle#27

Open

Add support for elasticsearch 8 sulu/SuluArticleBundle#606

Closed

pushrbx mentioned this pull request Apr 14, 2022

Search: Improve v4 search jikan-me/jikan-rest#189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Elasticsearch 8.x Support #18

Elasticsearch 8.x Support #18

hkulekci commented Feb 27, 2022

hkulekci commented Feb 27, 2022 •

edited

Loading

hkulekci commented Mar 2, 2022

alexander-schranz Mar 2, 2022

hkulekci Mar 2, 2022

alexander-schranz Mar 2, 2022

alexander-schranz Mar 2, 2022

hkulekci Mar 2, 2022

alexander-schranz left a comment

hkulekci commented Mar 2, 2022

hkulekci commented Mar 6, 2022 •

edited

Loading

hkulekci commented Mar 6, 2022 •

edited

Loading

hkulekci commented Mar 11, 2022

alexander-schranz commented Mar 12, 2022

hkulekci commented Mar 13, 2022

alexander-schranz commented Mar 25, 2022

hkulekci commented Mar 25, 2022

hkulekci commented Mar 25, 2022

hkulekci commented Mar 25, 2022

alexander-schranz commented Mar 25, 2022 •

edited

Loading

alexander-schranz commented Mar 25, 2022

hkulekci commented Mar 25, 2022 •

edited

Loading

alexander-schranz commented Mar 25, 2022

hkulekci commented Mar 25, 2022

alexander-schranz commented Mar 25, 2022

alexander-schranz commented Aug 16, 2022

Elasticsearch 8.x Support #18

Elasticsearch 8.x Support #18

Conversation

hkulekci commented Feb 27, 2022

hkulekci commented Feb 27, 2022 • edited Loading

hkulekci commented Mar 2, 2022

alexander-schranz Mar 2, 2022

Choose a reason for hiding this comment

hkulekci Mar 2, 2022

Choose a reason for hiding this comment

alexander-schranz Mar 2, 2022

Choose a reason for hiding this comment

alexander-schranz Mar 2, 2022

Choose a reason for hiding this comment

hkulekci Mar 2, 2022

Choose a reason for hiding this comment

alexander-schranz left a comment

Choose a reason for hiding this comment

hkulekci commented Mar 2, 2022

hkulekci commented Mar 6, 2022 • edited Loading

hkulekci commented Mar 6, 2022 • edited Loading

hkulekci commented Mar 11, 2022

alexander-schranz commented Mar 12, 2022

hkulekci commented Mar 13, 2022

alexander-schranz commented Mar 25, 2022

hkulekci commented Mar 25, 2022

hkulekci commented Mar 25, 2022

hkulekci commented Mar 25, 2022

alexander-schranz commented Mar 25, 2022 • edited Loading

alexander-schranz commented Mar 25, 2022

hkulekci commented Mar 25, 2022 • edited Loading

alexander-schranz commented Mar 25, 2022

hkulekci commented Mar 25, 2022

alexander-schranz commented Mar 25, 2022

alexander-schranz commented Aug 16, 2022

hkulekci commented Feb 27, 2022 •

edited

Loading

hkulekci commented Mar 6, 2022 •

edited

Loading

hkulekci commented Mar 6, 2022 •

edited

Loading

alexander-schranz commented Mar 25, 2022 •

edited

Loading

hkulekci commented Mar 25, 2022 •

edited

Loading