Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ADAM 0.18 #363

Merged
merged 2 commits into from
Nov 3, 2015
Merged

Upgrade to ADAM 0.18 #363

merged 2 commits into from
Nov 3, 2015

Conversation

arahuja
Copy link
Contributor

@arahuja arahuja commented Oct 31, 2015

This fixes issues with MdTag parsing in previous versions of ADAM for RNA data.

  • Some of the PileupSuite tests had to be updated to account for this

Review on Reviewable

@timodonnell
Copy link
Member

Thanks for taking care of this long-standing annoyance @arahuja . We should add back the failing test once your ADAM fix goes in (perhaps comment it out here?) LGTM

@arahuja
Copy link
Contributor Author

arahuja commented Nov 3, 2015

@timodonnell I'll open an issue with the relavant commit with the test so we can add it back. I do want to investigate first the usage of CIGAR P. We also have an odd comment on in it in PileupElement https://github.com/hammerlab/guacamole/blob/master/src/main/scala/org/hammerlab/guacamole/pileup/PileupElement.scala#L132-L133

arahuja added a commit that referenced this pull request Nov 3, 2015
@arahuja arahuja merged commit ec865d0 into master Nov 3, 2015
@arahuja arahuja deleted the adam018-upgrade branch November 3, 2015 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants