feat: allow setting zstd codec options #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrwiersma
reviewed
Jan 8, 2025
ocf/codec.go
Outdated
| DOptions []zstd.DOption | ||
| } | ||
|
|
||
| func resolveCodec(name CodecName, lvl int, zstdOpts zstdOptions) (Codec, error) { |
There was a problem hiding this comment.
Perhaps it would be best to have a codecOptions or codecConfig struct here containing the compression level and zstd options. Would make this cleaner in the long run.
There was a problem hiding this comment.
I was going for minimal diffs, but totally agree with having a codecOptions.
Updated, and also added a couple of test cases to ensure options make it to the zstd codec for both encoding and decoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ZStandard codec is used with its default settings, which in some cases are less than optimal.
This change allows setting options in the codec to configure it according to needs.