Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVERT] chore(packages): update import paths for internal packages #119

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

halvaradop
Copy link
Owner

@halvaradop halvaradop commented Feb 12, 2025

Description

This pull request reverts the changes introduced in pull request #112. For some reason, executing the pnpm dev script causes the application to break, even though the packages were previously built. One reason for this behavior is that pull request #112 added symbolic links between packages, creating dependencies among them. If the packages are not built yet, tsup will throw an error.

I believe one of the reasons for this behavior is that tsup.config.base has the clean field, which cleans the dist package every time a command using tsup is run, both in development and production.

Checklist

  • Added documentation.
  • The changes do not generate any warnings.
  • I have performed a self-review of my own code
  • All tests have been added and pass successfully

Notes

@halvaradop
Copy link
Owner Author

Although reverting the changes from pull request #112, the script pnpm dev still doesn't work correctly. Therefore, I believe the best approach is to figure out the root cause of the issue. It could be due to a dependency or possibly caused by cyclic imports between packages.

@halvaradop halvaradop marked this pull request as draft February 12, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant