-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Archives #225
Merged
Merged
[Feature] Archives #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tested this PR on my demo Hugo GitLab pages with comment reply at https://vincenttam.gitlab.io/bhdemo (source), which is created to test #222 This works great! Thank you @pad92 for your contributions. |
thx, it´s from even archive theme too
Le mer. 21 nov. 2018 à 12:57, Vincent Tam <notifications@github.com> a
écrit :
… I've tested this PR on my demo Hugo GitLab pages with comment reply at
https://vincenttam.gitlab.io/bhdemo (source
<https://gitlab.com/vincenttam/bhdemo>), which is created to test #222
<#222>
This works great! Thank you @pad92 <https://github.com/pad92> for your
contributions.
[image: archive]
<https://user-images.githubusercontent.com/5748535/48839785-dd5f1300-ed8c-11e8-8ad2-04f845efdffc.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#225 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBL3XiqN_9yAiEj94srmR7ONOGt7IQLks5uxT-SgaJpZM4YrC6J>
.
|
Closed
Due to #261, we should replace deprecated diff --git a/layouts/_default/section.html b/layouts/_default/section.html
index 3057cf1..6844096 100644
--- a/layouts/_default/section.html
+++ b/layouts/_default/section.html
@@ -34,7 +34,7 @@
{{ $element.Date.Format "01-02" }}
</span>
<span class="archive-post-title">
- <a href="{{ $element.URL }}" class="archive-post-link">
+ <a href="{{ $element.RelPermalink }}" class="archive-post-link">
{{ .Title }}
</a>
</span>
@@ -46,12 +46,12 @@
<ul class="pager main-pager">
{{ if .Paginator.HasPrev }}
<li class="previous">
- <a href="{{ .URL }}page/{{ .Paginator.Prev.PageNumber }}/">← {{ i18n "newerPosts" }}</a>
+ <a href="{{ .RelPermalink }}page/{{ .Paginator.Prev.PageNumber }}/">← {{ i18n "newerPosts" }}</a>
</li>
{{ end }}
{{ if .Paginator.HasNext }}
<li class="next">
- <a href="{{ .URL }}page/{{ .Paginator.Next.PageNumber }}/">{{ i18n "olderPosts" }} →</a>
+ <a href="{{ .RelPermalink }}page/{{ .Paginator.Next.PageNumber }}/">{{ i18n "olderPosts" }} →</a>
</li>
{{ end }}
</ul> |
change depreciated .URL to .RelPermalink thx @VincentTam
pad92
added a commit
to pad92/beautifulhugo
that referenced
this pull request
May 3, 2019
update from PR halogenica#225
Awesome stuff, thank you so much for this feature! |
shantanugoel
pushed a commit
to shantanugoel/beautifulhugo
that referenced
this pull request
Dec 30, 2019
[Feature] Archives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add archive page for #220