Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine cached response with writing and flushing #13

Merged

Conversation

JohnNiang
Copy link
Contributor

@JohnNiang JohnNiang commented Oct 14, 2024

优化缓存内容响应

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 14, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby October 14, 2024 09:39
Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang JohnNiang force-pushed the bug/missing-transfer-encoding branch from f290f04 to c1e32ad Compare October 14, 2024 14:15
@JohnNiang JohnNiang changed the title WIP: Fix the problem of not writing response with chunked Refine cached response with writing and flushing Oct 14, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2024
Copy link

f2c-ci-robot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 407b994 into halo-sigs:main Oct 14, 2024
2 checks passed
@JohnNiang JohnNiang deleted the bug/missing-transfer-encoding branch October 14, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants