Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

绑定检查有问题导致同一平台只能有一个用户可以绑定成功 #62

Closed
guqing opened this issue Sep 13, 2024 · 2 comments · Fixed by #63
Closed

绑定检查有问题导致同一平台只能有一个用户可以绑定成功 #62

guqing opened this issue Sep 13, 2024 · 2 comments · Fixed by #63
Assignees
@guqing

Comments

@guqing
Copy link
Member

guqing commented Sep 13, 2024

我启用了 gitlab 的 oauth2，

第一个系统用户绑定 gitlab正常，
第二个系统用户绑定 gitlab 时提示已经绑定过账号，要求先解绑，

这个是不是有点问题，按现在这样设计，gitlab，github，gitee，三个都启用起来，一共也只能绑定三个用户。

Originally posted by @jrongbin in #59 (comment)
@guqing
Copy link
Member Author

guqing commented Sep 13, 2024

问题描述： 当前的社交账号绑定逻辑只根据平台（例如 GitHub）进行检查，而忽略了用户名，导致一个用户绑定了某平台的账号后，其他用户无法绑定该平台的不同账号。
期望行为： 每个用户可以绑定一个特定平台的账号，不同用户可以绑定同一平台的不同账号。同一个用户不能绑定多个该平台的账号。

@guqing guqing mentioned this issue Sep 13, 2024
Merged
@guqing
Copy link
Member Author

guqing commented Sep 13, 2024

/king bug
/assign

f2c-ci-robot bot pushed a commit that referenced this issue Sep 13, 2024
@guqing
fix: ensure unique platform account binding per user (#63)
54e81a6 
### What this PR does?
修复了不同用户无法在同一平台绑定各自账号的问题

/kind bug

Fixes #62 

```release-note
修复了不同用户无法在同一平台绑定各自账号的问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure unique platform account binding per user halo-sigs/plugin-oauth2
1 participant
@guqing