Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add highlightjs code block extension to the editor #24

Merged
merged 9 commits into from
Sep 2, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 1, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

为编辑器提供 ExtensionCodeBlockLow 扩展,用于在编辑器代码块中增加基于 highlightjs 的高亮显示功能。

需要 PR halo-dev/halo#6428 的支持

How to test it?

测试启用插件后,编辑器代码块是否能够成功显示高亮并具有语言选项。

Does this PR introduce a user-facing change?

为默认编辑器提供代码块高亮扩展。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang August 1, 2024 09:09
@JohnNiang
Copy link
Contributor

Hi @LIlGG ,请先解决一下 CI 错误。

@LIlGG
Copy link
Member Author

LIlGG commented Aug 2, 2024

Hi @LIlGG ,请先解决一下 CI 错误。

需要 PR halo-dev/halo#6428 的支持。

@ruibaby ruibaby changed the title feat: add highlightjs code block extension to the editor WIP: feat: add highlightjs code block extension to the editor Aug 2, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2024
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby changed the title WIP: feat: add highlightjs code block extension to the editor feat: add highlightjs code block extension to the editor Sep 1, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 1, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby merged commit c245913 into halo-sigs:main Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants