-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add login expiration notification #6738
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6738 +/- ##
============================================
- Coverage 58.29% 57.82% -0.48%
- Complexity 3963 3990 +27
============================================
Files 680 704 +24
Lines 23338 23737 +399
Branches 1584 1572 -12
============================================
+ Hits 13604 13725 +121
- Misses 9108 9390 +282
+ Partials 626 622 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
/lgtm |
What type of PR is this?
/area ui
/kind improvement
/milestone 2.20.x
What this PR does / why we need it:
添加登录失效的引导。
Does this PR introduce a user-facing change?