Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redirecting to page according to query after authenticated #6736

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.0

What this PR does / why we need it:

This PR supports query redirect_uri to control where to redirect after authenticated.

Which issue(s) this PR fixes:

Fixes #6720

Special notes for your reviewer:

Every step below needs you logging out.

  1. Try to request <http://localhost:8090/console/login?redirect_uri=/xxx
  2. Try to request <http://localhost:8090/login?redirect_uri=/xxx
  3. Try to request <http://localhost:8090/console/posts

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 30, 2024
Copy link

f2c-ci-robot bot commented Sep 30, 2024

@JohnNiang: The provided milestone is not valid for this repository. Milestones in this repository: [2.18.x, 2.19.x, 2.20.0 LTS, 2.20.x, Backlog]

Use /milestone clear to clear the milestone.

In response to this:

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.0

What this PR does / why we need it:

This PR supports query redirect_uri to control where to redirect after authenticated.

Which issue(s) this PR fixes:

Fixes #6720

Special notes for your reviewer:

Every step below needs you logging out.

  1. Try to request <http://localhost:8090/console/login?redirect_uri=/xxx
  2. Try to request <http://localhost:8090/login?redirect_uri=/xxx
  3. Try to request <http://localhost:8090/console/posts

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 30, 2024
…ated

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@JohnNiang JohnNiang force-pushed the feat/support-redirect-uri-when-authenticating branch from e5a0009 to 2415b6e Compare September 30, 2024 10:20
Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
Copy link

f2c-ci-robot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.88%. Comparing base (982a45b) to head (0f62453).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...n/twofactor/TwoFactorAuthenticationEntryPoint.java 50.00% 2 Missing ⚠️
...alo/app/security/preauth/PreAuthLoginEndpoint.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6736      +/-   ##
============================================
- Coverage     58.29%   57.88%   -0.41%     
- Complexity     3963     4002      +39     
============================================
  Files           680      705      +25     
  Lines         23338    23777     +439     
  Branches       1584     1574      -10     
============================================
+ Hits          13604    13764     +160     
- Misses         9108     9391     +283     
+ Partials        626      622       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit db65dd3 into halo-dev:main Sep 30, 2024
8 checks passed
@JohnNiang JohnNiang deleted the feat/support-redirect-uri-when-authenticating branch September 30, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

兼容旧登录页面的 redirect_uri 参数
3 participants