-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support redirecting to page according to query after authenticated #6736
Support redirecting to page according to query after authenticated #6736
Conversation
@JohnNiang: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ated Signed-off-by: JohnNiang <johnniang@foxmail.com>
e5a0009
to
2415b6e
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6736 +/- ##
============================================
- Coverage 58.29% 57.88% -0.41%
- Complexity 3963 4002 +39
============================================
Files 680 705 +25
Lines 23338 23777 +439
Branches 1584 1574 -10
============================================
+ Hits 13604 13764 +160
- Misses 9108 9391 +283
+ Partials 626 622 -4 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind improvement
/area core
/milestone 2.20.0
What this PR does / why we need it:
This PR supports query
redirect_uri
to control where to redirect after authenticated.Which issue(s) this PR fixes:
Fixes #6720
Special notes for your reviewer:
Every step below needs you logging out.
Does this PR introduce a user-facing change?